From b6d7424042678a9eede5dd11e3adf43e203cfbab Mon Sep 17 00:00:00 2001 From: Naumov Alexey Date: Thu, 30 Dec 2021 02:00:23 +0300 Subject: [PATCH 1/4] fix(core-theming): CB-1458 form controls styles cleanup --- .../src/shared/InlineEditor/styles.ts | 14 ++--- .../core-blocks/src/FormControls/Combobox.tsx | 1 - .../src/FormControls/InputField.tsx | 1 - .../core-blocks/src/FormControls/Textarea.tsx | 3 +- .../core-blocks/src/ItemList/styles.ts | 3 +- .../ErrorDetailsDialog/ErrorDetailsDialog.tsx | 6 +-- .../ErrorDetailsDialog/styles.ts | 4 +- .../src/styles/_form-controls.scss | 54 ++++--------------- .../core-theming/src/styles/_theme-dark.scss | 17 +++--- .../core-theming/src/styles/_theme-light.scss | 3 ++ .../core-theming/src/styles/_variables.scss | 3 ++ 11 files changed, 38 insertions(+), 71 deletions(-) diff --git a/webapp/packages/core-app/src/shared/InlineEditor/styles.ts b/webapp/packages/core-app/src/shared/InlineEditor/styles.ts index 7d188606dc..615dd658ef 100644 --- a/webapp/packages/core-app/src/shared/InlineEditor/styles.ts +++ b/webapp/packages/core-app/src/shared/InlineEditor/styles.ts @@ -46,19 +46,15 @@ export const InlineEditorStyles = composes( position: relative; height: 100%; flex: 1; + display: flex; - & input { - color: inherit; - background: inherit; - letter-spacing: inherit; - outline: none; + & input, & input[disabled], & input[readonly] { border: none; - padding-left: 8px; - padding-right: 8px; - padding-top: 1px; /* because of -1px top */ - line-height: 24px; + border-radius: unset; width: 100%; height: 100%; + min-height: unset; + padding: 0 8px; } } diff --git a/webapp/packages/core-blocks/src/FormControls/Combobox.tsx b/webapp/packages/core-blocks/src/FormControls/Combobox.tsx index 429eb00c22..2fa053745b 100644 --- a/webapp/packages/core-blocks/src/FormControls/Combobox.tsx +++ b/webapp/packages/core-blocks/src/FormControls/Combobox.tsx @@ -332,7 +332,6 @@ export const Combobox: ComboboxType = observer(function Combobox({ )} {}, + onChange = () => { }, ...rest }: ControlledProps | ObjectProps) { const context = useContext(FormContext); @@ -106,7 +106,6 @@ export const Textarea: TextareaType = observer(function Textarea({ {children} +