From 906950fbe9755de069b9cd9b4d94b612b25fea22 Mon Sep 17 00:00:00 2001
From: Naumov Alexey <Iamemptyhuh@gmail.com>
Date: Thu, 1 Apr 2021 19:26:27 +0300
Subject: [PATCH] fix(core-blocks): CB-451 add missing tooltips

---
 webapp/packages/core-blocks/src/FormControls/InputField.tsx     | 2 +-
 webapp/packages/core-blocks/src/FormControls/InputFieldNew.tsx  | 2 +-
 .../src/ObjectPropertyInfoForm/ObjectPropertyInfoFormNew.tsx    | 1 +
 .../ServerConfiguration/Form/ServerConfigurationInfoForm.tsx    | 1 +
 webapp/packages/plugin-administration/src/locales/en.ts         | 1 +
 webapp/packages/plugin-administration/src/locales/ru.ts         | 1 +
 .../src/Dialog/AuthProviderForm/AuthProviderForm.tsx            | 1 +
 .../src/ObjectPropertiesPage/ObjectInfoTab/ObjectProperty.tsx   | 2 ++
 8 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/webapp/packages/core-blocks/src/FormControls/InputField.tsx b/webapp/packages/core-blocks/src/FormControls/InputField.tsx
index 4f4eb8e869..5cda6bd2c6 100644
--- a/webapp/packages/core-blocks/src/FormControls/InputField.tsx
+++ b/webapp/packages/core-blocks/src/FormControls/InputField.tsx
@@ -84,7 +84,7 @@ export const InputField: InputFieldType = observer(function InputField({
 
   return styled(styles)(
     <field as="div" className={className} {...use({ long, short })}>
-      <field-label as='label'>{children} {required && '*'}</field-label>
+      <field-label as='label' title={rest.title}>{children} {required && '*'}</field-label>
       <input
         {...rest}
         name={name}
diff --git a/webapp/packages/core-blocks/src/FormControls/InputFieldNew.tsx b/webapp/packages/core-blocks/src/FormControls/InputFieldNew.tsx
index bdbc6d80a1..eab775a1ec 100644
--- a/webapp/packages/core-blocks/src/FormControls/InputFieldNew.tsx
+++ b/webapp/packages/core-blocks/src/FormControls/InputFieldNew.tsx
@@ -108,7 +108,7 @@ export const InputFieldNew: InputFieldType = observer(function InputFieldNew({
 
   return styled(styles)(
     <field as="div" className={className} {...use({ small, medium, large })}>
-      <field-label as='label'>{children}{required && ' *'}</field-label>
+      <field-label as='label' title={rest.title}>{children}{required && ' *'}</field-label>
       <input
         ref={ref}
         role='new'
diff --git a/webapp/packages/core-blocks/src/ObjectPropertyInfoForm/ObjectPropertyInfoFormNew.tsx b/webapp/packages/core-blocks/src/ObjectPropertyInfoForm/ObjectPropertyInfoFormNew.tsx
index d2bfa23e56..75c9be682a 100644
--- a/webapp/packages/core-blocks/src/ObjectPropertyInfoForm/ObjectPropertyInfoFormNew.tsx
+++ b/webapp/packages/core-blocks/src/ObjectPropertyInfoForm/ObjectPropertyInfoFormNew.tsx
@@ -111,6 +111,7 @@ const RenderField: React.FC<RenderFieldProps> = observer(function RenderField({
   return (
     <InputFieldNew
       type={password ? 'password' : 'text'}
+      title={property.description}
       name={property.id!}
       state={state}
       description={description}
diff --git a/webapp/packages/plugin-administration/src/ConfigurationWizard/ServerConfiguration/Form/ServerConfigurationInfoForm.tsx b/webapp/packages/plugin-administration/src/ConfigurationWizard/ServerConfiguration/Form/ServerConfigurationInfoForm.tsx
index af943e3123..ce90213f68 100644
--- a/webapp/packages/plugin-administration/src/ConfigurationWizard/ServerConfiguration/Form/ServerConfigurationInfoForm.tsx
+++ b/webapp/packages/plugin-administration/src/ConfigurationWizard/ServerConfiguration/Form/ServerConfigurationInfoForm.tsx
@@ -38,6 +38,7 @@ export const ServerConfigurationInfoForm: React.FC<Props> = observer(function Se
         {translate('administration_configuration_wizard_configuration_server_name')}
       </InputFieldNew>
       <InputFieldNew
+        title={translate('administration_configuration_wizard_configuration_server_session_lifetime_description')}
         type="number"
         name="sessionExpireTime"
         state={state.serverConfig}
diff --git a/webapp/packages/plugin-administration/src/locales/en.ts b/webapp/packages/plugin-administration/src/locales/en.ts
index 99eaabea09..65eac90e24 100644
--- a/webapp/packages/plugin-administration/src/locales/en.ts
+++ b/webapp/packages/plugin-administration/src/locales/en.ts
@@ -14,6 +14,7 @@ export default [
   ['administration_configuration_wizard_configuration_server_info', 'Server Information'],
   ['administration_configuration_wizard_configuration_server_name', 'Server Name'],
   ['administration_configuration_wizard_configuration_server_session_lifetime', 'Session lifetime'],
+  ['administration_configuration_wizard_configuration_server_session_lifetime_description', 'Here you may specify the number of minutes that you wish the session to be allowed to remain idle before it expires'],
 
   ['administration_configuration_wizard_configuration_plugins', 'Configuration'],
   ['administration_configuration_wizard_configuration_custom_connections', 'Enable custom connections'],
diff --git a/webapp/packages/plugin-administration/src/locales/ru.ts b/webapp/packages/plugin-administration/src/locales/ru.ts
index db2831ea6e..e996b1e63b 100644
--- a/webapp/packages/plugin-administration/src/locales/ru.ts
+++ b/webapp/packages/plugin-administration/src/locales/ru.ts
@@ -1,6 +1,7 @@
 export default [
   ['administration_configuration_wizard_configuration', 'Настройки сервера'],
   ['administration_configuration_wizard_configuration_server_session_lifetime', 'Время сессии'],
+  ['administration_configuration_wizard_configuration_server_session_lifetime_description', 'В случае бездействия пользователя на протяжении указанного количества минут, его сессия будет закрыта.'],
   ['administration_configuration_wizard_configuration_custom_connections', 'Разрешить пользовательские подключения'],
   ['administration_configuration_wizard_configuration_custom_connections_description', 'Позволяет пользователям создавать собственные подключения. Иначе, любые подключения могут быть добавлены только со страницы администрирования'],
   ['administration_configuration_wizard_configuration_navigation_tree_view', 'Упрощенная версия дерева навигации'],
diff --git a/webapp/packages/plugin-authentication/src/Dialog/AuthProviderForm/AuthProviderForm.tsx b/webapp/packages/plugin-authentication/src/Dialog/AuthProviderForm/AuthProviderForm.tsx
index 6852779d20..9d99542743 100644
--- a/webapp/packages/plugin-authentication/src/Dialog/AuthProviderForm/AuthProviderForm.tsx
+++ b/webapp/packages/plugin-authentication/src/Dialog/AuthProviderForm/AuthProviderForm.tsx
@@ -37,6 +37,7 @@ export const AuthProviderForm = observer(function AuthProviderForm({
       {provider.credentialParameters.map(parameter => parameter.user && (
         <group key={parameter.id} as="div">
           <InputField
+            title={parameter.description}
             type={parameter.encryption === 'none' ? 'text' : 'password'}
             name={`authentication_${provider.id}_${parameter.id}`}
             value={credentials[parameter.id]}
diff --git a/webapp/packages/plugin-object-viewer/src/ObjectPropertiesPage/ObjectInfoTab/ObjectProperty.tsx b/webapp/packages/plugin-object-viewer/src/ObjectPropertiesPage/ObjectInfoTab/ObjectProperty.tsx
index 559ff4f3b4..4d5a16280b 100644
--- a/webapp/packages/plugin-object-viewer/src/ObjectPropertiesPage/ObjectInfoTab/ObjectProperty.tsx
+++ b/webapp/packages/plugin-object-viewer/src/ObjectPropertiesPage/ObjectInfoTab/ObjectProperty.tsx
@@ -27,6 +27,7 @@ export const ObjectProperty = observer(function ObjectProperty({
         ? (
           <FieldCheckboxNew
             className={className}
+            title={objectProperty.description}
             name={objectProperty.id}
             value={getValue(objectProperty.value)}
             disabled
@@ -38,6 +39,7 @@ export const ObjectProperty = observer(function ObjectProperty({
         : (
           <InputFieldNew
             className={className}
+            title={objectProperty.description}
             name={objectProperty.id}
             value={getValue(objectProperty.value)}
             readOnly