From 4ce12c794519ec15a0b3125a478e01d0aed7e838 Mon Sep 17 00:00:00 2001 From: Naumov Alexey Date: Tue, 13 Oct 2020 18:22:52 +0300 Subject: [PATCH] fix(plugin-data-spreadsheet): CB-418 copy cell by Cmd+C lowerCase CB-418 --- webapp/packages/plugin-data-export/src/locales/en.ts | 2 +- .../src/AgGridTable/modules/RangeSelection/rangeController.ts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/webapp/packages/plugin-data-export/src/locales/en.ts b/webapp/packages/plugin-data-export/src/locales/en.ts index c199614c5a..fdb84a18e1 100644 --- a/webapp/packages/plugin-data-export/src/locales/en.ts +++ b/webapp/packages/plugin-data-export/src/locales/en.ts @@ -4,7 +4,7 @@ export default [ ['data_transfer_dialog_configuration_title', 'Export configuration'], ['data_transfer_dialog_preparation', 'We prepare your file for export. Please wait...'], ['data_transfer_notification_preparation', 'We prepare your file for download. Please wait...'], - ['data_transfer_notification_ready', 'File ready to download'], + ['data_transfer_notification_ready', 'File is ready to download'], ['data_transfer_notification_error', 'Preparation failed or canceled'], ['data_transfer_notification_download', 'Download'], ['data_transfer_notification_delete', 'Delete'], diff --git a/webapp/packages/plugin-data-spreadsheet/src/AgGridTable/modules/RangeSelection/rangeController.ts b/webapp/packages/plugin-data-spreadsheet/src/AgGridTable/modules/RangeSelection/rangeController.ts index 23c8a60c57..00b8b0fc3a 100644 --- a/webapp/packages/plugin-data-spreadsheet/src/AgGridTable/modules/RangeSelection/rangeController.ts +++ b/webapp/packages/plugin-data-spreadsheet/src/AgGridTable/modules/RangeSelection/rangeController.ts @@ -45,7 +45,7 @@ interface CellKeyDownEvent extends AgGridEvent{ } const EVENT_KEY_CODE = { - C: 'c', + C: 'KeyC', }; interface TemporarySelectionRange { @@ -103,7 +103,7 @@ export class RangeController implements IRangeController { } private handleDocumentCopy(event: KeyboardEvent) { - if (event.key.toLowerCase() === EVENT_KEY_CODE.C && (event.ctrlKey || event.metaKey)) { + if (event.code === EVENT_KEY_CODE.C && (event.ctrlKey || event.metaKey)) { this.copySelectedData(); } }