mirror of
https://github.com/cline/cline.git
synced 2026-08-28 19:48:08 +08:00
Mikołaj Kondratek
a5ac26f279
* fix(vscode): clear task-scoped settings overlay when task view is cleared or switched Toggling an auto-approve setting while a task is open writes autoApprovalSettings into the StateManager's task-settings overlay (updateAutoApprovalSettings -> setTaskSettings). The SDK controller never cleared that overlay on clearTask/showTaskWithId (the legacy controller did), so after New Task the stale overlay kept shadowing global settings in getGlobalSettingsKey(): toggle RPCs were accepted into global state, but every posted state still carried the overlay's old version, which the webview rejects as not newer - the auto-approve checkboxes froze forever. Restore legacy parity in SdkTaskControlCoordinator: drop the overlay (persisting pending writes first) in clearTask() and before installing a different task's proxy in showTaskWithId(). Fixes #13260 Co-authored-by: Saoud Rizwan <saoudrizwan@users.noreply.github.com> * changeset * test(vscode): add end-to-end regression test for auto-approve freeze after New Task Wires the real StateManager, the real updateAutoApprovalSettings handler, and the real SdkTaskControlCoordinator.clearTask() together with the webview's version gate modeled on ExtensionStateContext, pinning the end-to-end invariant behind #13260: checkbox toggles must keep reaching the webview after a mid-task toggle followed by New Task. Verified the test fails when the clearTaskSettings() call is removed from clearTask(). * fix implicit any in regression test --------- Co-authored-by: Saoud Rizwan <7799382+saoudrizwan@users.noreply.github.com> Co-authored-by: Saoud Rizwan <saoudrizwan@users.noreply.github.com>