From 7ec918261cdf5d802536e7c40b406cd152ca987d Mon Sep 17 00:00:00 2001
From: celestial-vault <58194240+celestial-vault@users.noreply.github.com>
Date: Wed, 10 Sep 2025 19:57:19 -0700
Subject: [PATCH] Clean up HistoryView: remove debug logs and unused code
 (#6133)

- Remove console.info debug statement from deleteTaskWithId
- Rename filteredTasks to tasks for clarity
- Remove unused presentableTasks variable
- Remove commented out empty state UI code
---
 .../controller/task/deleteTasksWithIds.ts     |  2 --
 .../src/components/history/HistoryView.tsx    | 32 ++++---------------
 2 files changed, 7 insertions(+), 27 deletions(-)

diff --git a/src/core/controller/task/deleteTasksWithIds.ts b/src/core/controller/task/deleteTasksWithIds.ts
index fc5f5bfcee..f0ebfdaa46 100644
--- a/src/core/controller/task/deleteTasksWithIds.ts
+++ b/src/core/controller/task/deleteTasksWithIds.ts
@@ -47,8 +47,6 @@ export async function deleteTasksWithIds(controller: Controller, request: String
  * @param id The task ID to delete
  */
 async function deleteTaskWithId(controller: Controller, id: string): Promise<void> {
-	console.info("deleteTaskWithId: ", id)
-
 	try {
 		// Clear current task if it matches the ID being deleted
 		if (id === controller.task?.taskId) {
diff --git a/webview-ui/src/components/history/HistoryView.tsx b/webview-ui/src/components/history/HistoryView.tsx
index f58bb009eb..e3d777ef8a 100644
--- a/webview-ui/src/components/history/HistoryView.tsx
+++ b/webview-ui/src/components/history/HistoryView.tsx
@@ -59,7 +59,7 @@ const HistoryView = ({ onDone }: HistoryViewProps) => {
 	const [pendingFavoriteToggles, setPendingFavoriteToggles] = useState<Record<string, boolean>>({})
 
 	// Load filtered task history with gRPC
-	const [filteredTasks, setFilteredTasks] = useState<any[]>([])
+	const [tasks, setTasks] = useState<any[]>([])
 
 	// Load and refresh task history
 	const loadTaskHistory = useCallback(async () => {
@@ -72,7 +72,7 @@ const HistoryView = ({ onDone }: HistoryViewProps) => {
 					currentWorkspaceOnly: showCurrentWorkspaceOnly,
 				}),
 			)
-			setFilteredTasks(response.tasks || [])
+			setTasks(response.tasks || [])
 		} catch (error) {
 			console.error("Error loading task history:", error)
 		}
@@ -83,7 +83,7 @@ const HistoryView = ({ onDone }: HistoryViewProps) => {
 		// Force a complete refresh when both filters are active
 		// to ensure proper combined filtering
 		if (showFavoritesOnly && showCurrentWorkspaceOnly) {
-			setFilteredTasks([])
+			setTasks([])
 		}
 		loadTaskHistory()
 	}, [loadTaskHistory, showFavoritesOnly, showCurrentWorkspaceOnly])
@@ -214,10 +214,8 @@ const HistoryView = ({ onDone }: HistoryViewProps) => {
 			.toUpperCase()
 	}, [])
 
-	const presentableTasks = useMemo(() => filteredTasks, [filteredTasks])
-
 	const fuse = useMemo(() => {
-		return new Fuse(presentableTasks, {
+		return new Fuse(tasks, {
 			keys: ["task"],
 			threshold: 0.6,
 			shouldSort: true,
@@ -226,10 +224,10 @@ const HistoryView = ({ onDone }: HistoryViewProps) => {
 			includeMatches: true,
 			minMatchCharLength: 1,
 		})
-	}, [presentableTasks])
+	}, [tasks])
 
 	const taskHistorySearchResults = useMemo(() => {
-		const results = searchQuery ? highlight(fuse.search(searchQuery)) : presentableTasks
+		const results = searchQuery ? highlight(fuse.search(searchQuery)) : tasks
 
 		results.sort((a, b) => {
 			switch (sortOption) {
@@ -255,7 +253,7 @@ const HistoryView = ({ onDone }: HistoryViewProps) => {
 		})
 
 		return results
-	}, [presentableTasks, searchQuery, fuse, sortOption])
+	}, [tasks, searchQuery, fuse, sortOption])
 
 	// Calculate total size of selected items
 	const selectedItemsSize = useMemo(() => {
@@ -400,22 +398,6 @@ const HistoryView = ({ onDone }: HistoryViewProps) => {
 					</div>
 				</div>
 				<div style={{ flexGrow: 1, overflowY: "auto", margin: 0 }}>
-					{/* {presentableTasks.length === 0 && (
-						<div
-							style={{
-								
-								alignItems: "center",
-								fontStyle: "italic",
-								color: "var(--vscode-descriptionForeground)",
-								textAlign: "center",
-								padding: "0px 10px",
-							}}>
-							<span
-								className="codicon codicon-robot"
-								style={{ fontSize: "60px", marginBottom: "10px" }}></span>
-							<div>Start a task to see it here</div>
-						</div>
-					)} */}
 					<Virtuoso
 						data={taskHistorySearchResults}
 						itemContent={(index, item) => (