mirror of
https://github.com/Tencent/WeKnora.git
synced 2026-09-01 14:53:07 +08:00
59132a56f6
Adds the three management verbs missing from v0.4's agent subtree (create / edit / delete) and expands v0.4-shipped agent view to render all 34 AgentConfig fields in human output (was 7). Surface: hot-path flags (--model required + 7 optional) + --config-file YAML/JSON tail + --generate-skeleton template emit. Flag > file > server-default precedence for hybrid invocation. - agent create <name> --model <id> [flags] + --from <agent-id> for copy-then-overlay (CopyAgent + UpdateAgent); preserves source config except for fields explicitly overridden - agent edit <id> with --add-kb / --remove-kb idempotent pair, L-2 fetch-then-update, at-least-one-flag validation, --description "" clearing via Flags().Changed(). --config-file fully replaces the AgentConfig baseline (use surgical flags for partial edits; the Long help spells this out + a test pins the contract). - agent delete <id> with ConfirmDestructive + exit-10 protocol; 404 propagates resource.not_found (not idempotent) - agent view: 10 grouped sections (Identity / LLM / KB attachment / Retrieval / Query rewrite / Tools / FAQ / Web search / Multi-turn / Fallback / Templates); --json field discovery includes all config.* keys Shared helper cli/internal/cmdutil/agentconfig.go handles YAML/JSON parsing, flag-overlay-file fusion, and skeleton emission.
98 lines
3.3 KiB
Go
98 lines
3.3 KiB
Go
package agentcmd
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
|
|
"github.com/spf13/cobra"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
|
|
"github.com/Tencent/WeKnora/cli/internal/iostreams"
|
|
"github.com/Tencent/WeKnora/cli/internal/prompt"
|
|
)
|
|
|
|
// agentDeleteFields enumerates the JSON discovery fields for `agent delete`.
|
|
// Result payload is a tiny {id, deleted} object — mirrors `kb delete`.
|
|
var agentDeleteFields = []string{"id", "deleted"}
|
|
|
|
// DeleteOptions captures `agent delete` flag state.
|
|
type DeleteOptions struct {
|
|
AgentID string
|
|
Yes bool // sourced from the global -y/--yes persistent flag
|
|
}
|
|
|
|
// DeleteService is the narrow SDK surface this command depends on.
|
|
type DeleteService interface {
|
|
DeleteAgent(ctx context.Context, id string) error
|
|
}
|
|
|
|
// deleteResult is the typed payload emitted on success in JSON mode.
|
|
type deleteResult struct {
|
|
ID string `json:"id"`
|
|
Deleted bool `json:"deleted"`
|
|
}
|
|
|
|
// Delete is NOT idempotent on a missing id — it surfaces resource.not_found
|
|
// rather than silently exiting 0. Idempotent-already-true semantics are
|
|
// reserved for unlink-style local cleanups, not server-side resource removal.
|
|
const agentDeleteLong = `Permanently delete a custom agent.
|
|
|
|
Prompts for confirmation by default when stdout is a TTY and --json is
|
|
not set. Pass -y/--yes (the global flag) to skip the prompt (required in
|
|
agent / CI / piped contexts).
|
|
|
|
Typed exit codes:
|
|
resource.not_found no agent with the given id (exit 4)
|
|
auth.forbidden caller lacks delete permission on the agent (exit 3)
|
|
input.confirmation_required destructive op without -y on a TTY (exit 10)
|
|
|
|
AI agents: This is a high-risk write. Without -y/--yes the CLI exits 10
|
|
and writes input.confirmation_required to stderr. NEVER auto-pass -y
|
|
without the user's explicit go-ahead — the exit-10 protocol exists
|
|
exactly to guard against unintended deletes.`
|
|
|
|
const agentDeleteExample = ` weknora agent delete ag_abc # interactive confirm
|
|
weknora agent delete ag_abc -y # no prompt
|
|
weknora agent delete ag_abc -y --json # bare {id, deleted:true} JSON`
|
|
|
|
// NewCmdDelete builds `weknora agent delete <agent-id>`.
|
|
func NewCmdDelete(f *cmdutil.Factory) *cobra.Command {
|
|
opts := &DeleteOptions{}
|
|
cmd := &cobra.Command{
|
|
Use: "delete <agent-id>",
|
|
Short: "Delete a custom agent",
|
|
Long: agentDeleteLong,
|
|
Example: agentDeleteExample,
|
|
Args: cobra.ExactArgs(1),
|
|
RunE: func(cmd *cobra.Command, args []string) error {
|
|
jopts, err := cmdutil.CheckJSONFlags(cmd)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
opts.AgentID = args[0]
|
|
opts.Yes, _ = cmd.Flags().GetBool("yes")
|
|
cli, err := f.Client()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
return runDelete(cmd.Context(), opts, jopts, cli, f.Prompter())
|
|
},
|
|
}
|
|
cmdutil.AddJSONFlags(cmd, agentDeleteFields)
|
|
return cmd
|
|
}
|
|
|
|
func runDelete(ctx context.Context, opts *DeleteOptions, jopts *cmdutil.JSONOptions, svc DeleteService, p prompt.Prompter) error {
|
|
if err := cmdutil.ConfirmDestructive(p, opts.Yes, jopts.Enabled(), "agent", opts.AgentID); err != nil {
|
|
return err
|
|
}
|
|
if err := svc.DeleteAgent(ctx, opts.AgentID); err != nil {
|
|
return cmdutil.WrapHTTP(err, "delete agent %s", opts.AgentID)
|
|
}
|
|
if jopts.Enabled() {
|
|
return jopts.Emit(iostreams.IO.Out, deleteResult{ID: opts.AgentID, Deleted: true})
|
|
}
|
|
fmt.Fprintf(iostreams.IO.Out, "✓ Deleted agent %s\n", opts.AgentID)
|
|
return nil
|
|
}
|