mirror of
https://github.com/Tencent/WeKnora.git
synced 2026-08-31 00:50:02 +08:00
da9faa9e07
Borrows the lark-cli agent-affordance model (https://github.com/larksuite/cli/blob/main/AGENTS.md + skills/lark-shared/SKILL.md) so weknora is designed to be agent-friendly: error messages, output format, and flag design follow conventions agents can rely on. cli/AGENTS.md (operational reference for LLM agents invoking weknora): Public document covering envelope schema, exit-code protocol (0/1/2/10/130), stdout/stderr separation, and behavioral rules. Sensitive commands (\`context use\`, \`kb delete\`, \`doc delete\`, \`init\`) gain "AI agents:" paragraphs in their cobra Long descriptions so guidance shows in --help. format.Envelope schema additions: Risk per-operation classification (read / write / high-risk-write + action description), populated by write commands on both success and failure paths. Notice system advisories (CLI update available, server-CLI version skew); type defined, emit sites land in v0.3. DryRun marker for envelopes returned from --dry-run preview paths. RiskLevel constants realigned to lark's taxonomy: read / write / high-risk-write (was: read / mutating / destructive — not yet wired by any command). cmdutil.Error gains OperationRisk; PrintErrorEnvelope auto-attaches it to envelope.Risk so destructive failure paths surface uniformly. Exit-10 confirmation protocol: New ErrorCode \`input.confirmation_required\` mapped to exit code 10 in cmdutil.ExitCode. ConfirmDestructive now returns this code (with OperationRisk attached) when stdout is non-TTY or --json was set, with -y/--yes absent. Previous behavior — silent proceed in non-TTY — was unsafe: scripts and agents could delete resources with no explicit approval. Three test cases re-pinned around the new contract. This is a wire-contract change for any caller who relied on silent proceed; v0.0/v0.1 had no destructive commands, so the blast radius is contained to v0.2 itself. --dry-run global flag: cmd write paths (kb create/delete, doc upload/delete, api POST/PUT/PATCH/ DELETE) check cmdutil.IsDryRun(cmd) and skip the SDK call, emitting an envelope with dry_run=true plus a Risk classification. Read commands ignore --dry-run by design (no side effect to preview). Human-mode prints \`[dry-run] would <action>\` to stdout. Command discovery: agents introspect via the existing \`--help\` surface (consistent with gh / kubectl / aws / gcloud / terraform — none of them ship a CLI-tree self-description command). An earlier draft added a \`weknora schema\` reflection command; dropped after a mainstream survey found it has no stable analog (lark-cli's schema describes Lark API methods, not its own CLI tree). Tests: 27 cli packages pass at this commit. Added two new tests covering envelope.risk and envelope._notice serialization.
197 lines
6.5 KiB
Go
197 lines
6.5 KiB
Go
package cmdutil
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
"io"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/format"
|
|
)
|
|
|
|
// ExitCode maps an error to the documented CLI exit code (spec §2.4 + ADR-3).
|
|
// Mirrors gh / Stripe / lark-cli convention:
|
|
// - 0 success
|
|
// - 1 generic / unknown typed error
|
|
// - 2 flag / argument problem
|
|
// - 3 auth.*
|
|
// - 4 resource.not_found
|
|
// - 5 input.* (other than confirmation_required)
|
|
// - 6 server.rate_limited
|
|
// - 7 server.* (other) / network.*
|
|
// - 10 input.confirmation_required — high-risk write needs explicit -y
|
|
// (lark-cli skill protocol; see cli/AGENTS.md)
|
|
// - 130 SIGINT (handled by Go runtime, not this function)
|
|
func ExitCode(err error) int {
|
|
if err == nil {
|
|
return 0
|
|
}
|
|
var fe *FlagError
|
|
if errors.As(err, &fe) {
|
|
return 2
|
|
}
|
|
if errors.Is(err, SilentError) {
|
|
return 1
|
|
}
|
|
if matchCode(err, CodeInputConfirmationRequired) {
|
|
return 10
|
|
}
|
|
if IsAuthError(err) {
|
|
return 3
|
|
}
|
|
if IsNotFound(err) {
|
|
return 4
|
|
}
|
|
if matchPrefix(err, "input.") {
|
|
return 5
|
|
}
|
|
if matchCode(err, CodeServerRateLimited) {
|
|
return 6
|
|
}
|
|
if matchPrefix(err, "server.") || matchPrefix(err, "network.") {
|
|
return 7
|
|
}
|
|
return 1
|
|
}
|
|
|
|
// PrintError writes err to w in human-readable form. The envelope-aware
|
|
// JSON formatter is in `internal/format`; this helper is the human path used
|
|
// when no command produced its own output.
|
|
//
|
|
// Typed *Error values surface their Hint as a second line so users see the
|
|
// actionable next-step (matches envelope.error.hint visibility in --json).
|
|
// Falls through to defaultHint when caller didn't set one.
|
|
func PrintError(w io.Writer, err error) {
|
|
if err == nil || errors.Is(err, SilentError) {
|
|
return
|
|
}
|
|
fmt.Fprintln(w, err.Error())
|
|
var typed *Error
|
|
if errors.As(err, &typed) {
|
|
hint := typed.Hint
|
|
if hint == "" {
|
|
hint = defaultHint(typed.Code)
|
|
}
|
|
if hint != "" {
|
|
fmt.Fprintf(w, "hint: %s\n", hint)
|
|
}
|
|
}
|
|
}
|
|
|
|
// PrintErrorEnvelope writes err as a JSON envelope on w. Used in agent mode /
|
|
// --json / --format=json output so failures stay machine-parseable. When the
|
|
// error carries an OperationRisk (destructive write paths), it's surfaced as
|
|
// the envelope-level Risk field so agents can decide whether to surface the
|
|
// failure differently to the user.
|
|
func PrintErrorEnvelope(w io.Writer, err error) {
|
|
if err == nil || errors.Is(err, SilentError) {
|
|
return
|
|
}
|
|
env := format.Failure(ToErrorBody(err))
|
|
if r := operationRiskOf(err); r != nil {
|
|
env.Risk = &format.Risk{Level: format.RiskLevel(r.Level), Action: r.Action}
|
|
}
|
|
_ = format.WriteEnvelope(w, env)
|
|
}
|
|
|
|
// operationRiskOf extracts an OperationRisk from a typed *Error chain, or nil.
|
|
func operationRiskOf(err error) *OperationRisk {
|
|
var typed *Error
|
|
if errors.As(err, &typed) {
|
|
return typed.OperationRisk
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// ToErrorBody projects err into the canonical envelope ErrorBody. Exposed so
|
|
// other emit paths (planned: MCP) reuse the same projection rather than
|
|
// reimplementing the typed-error → wire-shape mapping.
|
|
func ToErrorBody(err error) *format.ErrorBody {
|
|
if err == nil {
|
|
return nil
|
|
}
|
|
body := &format.ErrorBody{Message: err.Error()}
|
|
var typed *Error
|
|
if errors.As(err, &typed) {
|
|
body.Code = string(typed.Code)
|
|
body.Message = typed.Message
|
|
body.Hint = typed.Hint
|
|
if body.Hint == "" {
|
|
body.Hint = defaultHint(typed.Code)
|
|
}
|
|
body.Retryable = typed.Retryable
|
|
// Surface the wrapped cause so agents see the actual server / SDK
|
|
// error string, not just the wrap message ("hybrid search"). Stripe's
|
|
// envelope does the same — the human's printed line and the JSON
|
|
// envelope both end with the underlying problem.
|
|
if typed.Cause != nil {
|
|
body.Message = typed.Message + ": " + typed.Cause.Error()
|
|
}
|
|
return body
|
|
}
|
|
var fe *FlagError
|
|
if errors.As(err, &fe) {
|
|
body.Code = string(CodeInputInvalidArgument)
|
|
return body
|
|
}
|
|
// Unclassified error; consumers see the message but no stable code.
|
|
body.Code = string(CodeServerError)
|
|
return body
|
|
}
|
|
|
|
// defaultHint returns a canonical actionable hint for known error codes when
|
|
// the call site didn't set one. Spec §1.4 zero-config matrix mandates
|
|
// `auth.unauthenticated` envelopes carry "run weknora auth login" — this
|
|
// fallback covers the broad surface (whoami / auth status / kb list / kb get
|
|
// / search) without per-command hint plumbing.
|
|
//
|
|
// Empty string for codes without a stable canonical hint.
|
|
func defaultHint(code ErrorCode) string {
|
|
switch code {
|
|
case CodeAuthUnauthenticated, CodeAuthBadCredential:
|
|
return "run `weknora auth login`"
|
|
case CodeAuthTokenExpired:
|
|
return "your session expired; run `weknora auth login` to re-authenticate"
|
|
case CodeAuthForbidden:
|
|
return "active context lacks permission for this resource"
|
|
case CodeAuthCrossTenantBlocked, CodeAuthTenantMismatch:
|
|
return "verify tenant context with `weknora whoami`"
|
|
case CodeNetworkError:
|
|
return "check base URL reachability with `weknora doctor`"
|
|
case CodeServerIncompatibleVersion:
|
|
return "run `weknora doctor` to see version skew details"
|
|
case CodeServerRateLimited:
|
|
return "rate-limited; retry after a few seconds"
|
|
case CodeServerTimeout:
|
|
return "request timed out; retry, or run `weknora doctor` to check connectivity"
|
|
case CodeResourceNotFound:
|
|
return "verify the resource ID; list available with `weknora kb list`"
|
|
case CodeInputInvalidArgument, CodeInputMissingFlag:
|
|
return "see `weknora <command> --help` for valid usage"
|
|
case CodeInputConfirmationRequired:
|
|
return "high-risk write — re-run with -y/--yes after the user explicitly approves"
|
|
case CodeLocalKeychainDenied:
|
|
return "verify keyring access; falls back to file storage"
|
|
case CodeLocalConfigCorrupt:
|
|
return "remove ~/.config/weknora/config.yaml and re-run `weknora auth login`"
|
|
case CodeLocalFileIO:
|
|
return "check file permissions under $XDG_CONFIG_HOME/weknora/"
|
|
case CodeKBIDRequired:
|
|
return "run `weknora init` to link a knowledge base, or pass --kb-id"
|
|
case CodeKBNotFound:
|
|
return "list available with `weknora kb list`"
|
|
case CodeProjectAlreadyLinked:
|
|
return "use --force to overwrite, or `weknora link` to update"
|
|
case CodeProjectLinkCorrupt:
|
|
return "remove .weknora/project.yaml and run `weknora init` again"
|
|
case CodeUserAborted:
|
|
return "no action taken; pass -y/--yes to skip the confirmation prompt"
|
|
case CodeUploadFileNotFound:
|
|
return "verify the path is correct and readable"
|
|
case CodeSSEStreamAborted:
|
|
return "the streaming answer was cut off mid-flight; retry, or pass --no-stream to buffer the full response"
|
|
case CodeSessionCreateFailed:
|
|
return "could not create a chat session; pass --session-id to reuse an existing session"
|
|
}
|
|
return ""
|
|
}
|