mirror of
https://github.com/Tencent/WeKnora.git
synced 2026-09-01 14:53:07 +08:00
nullkey
f2e8e3f56c
Survey of 10 mainstream CLIs (gh, lark, stripe, vercel, supabase, aws, azure, gcloud, openai/codex, github-copilot-cli) showed env-gated per-command --help blurbs are a Stripe-only pattern; gh uses env detect for telemetry only, and lark relies on installed agent Skills + MCP. Our cmd/mcp/serve already covers the dominant 2025/26 path, so internal/aiclient/ (136 LOC + 38 callsites) is net maintenance burden without precedent. - Drop internal/aiclient/ entirely (annotations + detect + tests) - Remove 38 SetAgentHelp callsites + agentAwareHelpFunc / SetHelpFunc wiring in cmd/root.go - Migrate 4 command-level rules to standard Long help (visible to all, not env-gated): doc upload mode mutex, kb edit at-least-one, kb pin idempotent, search chunks channel mutex - Rewrite AGENTS.md as a developer guide (gh-style 6 H2 / 167 lines): audience preamble + Build / Architecture / Command Structure / Testing / Code Style / Error Handling. Drops sections absent in surveyed projects (Commit & PR Conventions, Who Uses This CLI) - Clean 14 internal doc refs (ADR-N, spec §X, v0.X) in source comments and docs that pointed at docs/superpowers/ — that directory is local-only / uncommitted, so refs are dead for outside readers - Drop forward-looking "once v0.2 ships" from README
52 lines
1.7 KiB
Go
52 lines
1.7 KiB
Go
package cmdutil
|
|
|
|
import (
|
|
"fmt"
|
|
"net/url"
|
|
"strings"
|
|
)
|
|
|
|
// NormalizeHost validates and canonicalizes a `--host` value. Trailing
|
|
// slashes are trimmed. Every failure path returns CodeInputInvalidArgument -
|
|
// a present-but-empty flag is treated as a bad value, not as a missing flag
|
|
// (cobra's required-flag layer is what catches the absent case).
|
|
//
|
|
// Rules:
|
|
// - non-empty
|
|
// - scheme is http or https
|
|
// - URL parses
|
|
// - u.Host is non-empty (rejects "http://" which url.Parse accepts)
|
|
func NormalizeHost(host string) (string, error) {
|
|
host = strings.TrimRight(strings.TrimSpace(host), "/")
|
|
if host == "" {
|
|
return "", NewError(CodeInputInvalidArgument, "--host must not be empty")
|
|
}
|
|
if err := ValidateHTTPURL("--host", host); err != nil {
|
|
return "", err
|
|
}
|
|
return host, nil
|
|
}
|
|
|
|
// ValidateHTTPURL applies the same http/https URL rules NormalizeHost uses,
|
|
// but parameterized by flagLabel so error messages name the caller's flag
|
|
// (e.g. "--host", "--from-url"). Returns CodeInputInvalidArgument on any
|
|
// failure. Empty `value` is not pre-checked here - callers that distinguish
|
|
// "missing" from "malformed" should test for empty before calling.
|
|
func ValidateHTTPURL(flagLabel, value string) error {
|
|
u, err := url.Parse(value)
|
|
if err != nil {
|
|
return NewError(CodeInputInvalidArgument, fmt.Sprintf("%s %q is not a valid URL: %v", flagLabel, value, err))
|
|
}
|
|
if u.Scheme != "http" && u.Scheme != "https" {
|
|
return &Error{
|
|
Code: CodeInputInvalidArgument,
|
|
Message: fmt.Sprintf("%s scheme must be http or https, got %q", flagLabel, u.Scheme),
|
|
Hint: "example: https://kb.example.com",
|
|
}
|
|
}
|
|
if u.Host == "" {
|
|
return NewError(CodeInputInvalidArgument, fmt.Sprintf("%s %q is missing the host portion", flagLabel, value))
|
|
}
|
|
return nil
|
|
}
|