mirror of
https://github.com/Tencent/WeKnora.git
synced 2026-08-31 00:50:02 +08:00
f2e8e3f56c
Survey of 10 mainstream CLIs (gh, lark, stripe, vercel, supabase, aws, azure, gcloud, openai/codex, github-copilot-cli) showed env-gated per-command --help blurbs are a Stripe-only pattern; gh uses env detect for telemetry only, and lark relies on installed agent Skills + MCP. Our cmd/mcp/serve already covers the dominant 2025/26 path, so internal/aiclient/ (136 LOC + 38 callsites) is net maintenance burden without precedent. - Drop internal/aiclient/ entirely (annotations + detect + tests) - Remove 38 SetAgentHelp callsites + agentAwareHelpFunc / SetHelpFunc wiring in cmd/root.go - Migrate 4 command-level rules to standard Long help (visible to all, not env-gated): doc upload mode mutex, kb edit at-least-one, kb pin idempotent, search chunks channel mutex - Rewrite AGENTS.md as a developer guide (gh-style 6 H2 / 167 lines): audience preamble + Build / Architecture / Command Structure / Testing / Code Style / Error Handling. Drops sections absent in surveyed projects (Commit & PR Conventions, Who Uses This CLI) - Clean 14 internal doc refs (ADR-N, spec §X, v0.X) in source comments and docs that pointed at docs/superpowers/ — that directory is local-only / uncommitted, so refs are dead for outside readers - Drop forward-looking "once v0.2 ships" from README
58 lines
1.3 KiB
Go
58 lines
1.3 KiB
Go
package cmdutil_test
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
|
|
)
|
|
|
|
func TestAllCodes_NonEmpty(t *testing.T) {
|
|
codes := cmdutil.AllCodes()
|
|
if len(codes) == 0 {
|
|
t.Fatal("AllCodes() should return registered codes")
|
|
}
|
|
// Sentinel: contains the baseline error codes the registry must always carry.
|
|
want := map[cmdutil.ErrorCode]bool{
|
|
cmdutil.CodeAuthUnauthenticated: false,
|
|
cmdutil.CodeResourceNotFound: false,
|
|
cmdutil.CodeNetworkError: false,
|
|
}
|
|
for _, c := range codes {
|
|
if _, ok := want[c]; ok {
|
|
want[c] = true
|
|
}
|
|
}
|
|
for c, ok := range want {
|
|
if !ok {
|
|
t.Errorf("AllCodes() missing %q", c)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestAllCodes_NoDuplicates(t *testing.T) {
|
|
codes := cmdutil.AllCodes()
|
|
seen := make(map[cmdutil.ErrorCode]struct{})
|
|
for _, c := range codes {
|
|
if _, dup := seen[c]; dup {
|
|
t.Errorf("AllCodes() duplicate: %q", c)
|
|
}
|
|
seen[c] = struct{}{}
|
|
}
|
|
}
|
|
|
|
func TestClassifyHTTPErrorOutputs_Subset(t *testing.T) {
|
|
outs := cmdutil.ClassifyHTTPErrorOutputs()
|
|
all := make(map[cmdutil.ErrorCode]struct{})
|
|
for _, c := range cmdutil.AllCodes() {
|
|
all[c] = struct{}{}
|
|
}
|
|
for _, c := range outs {
|
|
if _, ok := all[c]; !ok {
|
|
t.Errorf("ClassifyHTTPErrorOutputs returns %q which is not in AllCodes", c)
|
|
}
|
|
}
|
|
if len(outs) < 5 {
|
|
t.Errorf("expected at least 5 codes, got %d", len(outs))
|
|
}
|
|
}
|