mirror of
https://github.com/Tencent/WeKnora.git
synced 2026-09-21 05:43:43 +08:00
nullkey
f2e8e3f56c
Survey of 10 mainstream CLIs (gh, lark, stripe, vercel, supabase, aws, azure, gcloud, openai/codex, github-copilot-cli) showed env-gated per-command --help blurbs are a Stripe-only pattern; gh uses env detect for telemetry only, and lark relies on installed agent Skills + MCP. Our cmd/mcp/serve already covers the dominant 2025/26 path, so internal/aiclient/ (136 LOC + 38 callsites) is net maintenance burden without precedent. - Drop internal/aiclient/ entirely (annotations + detect + tests) - Remove 38 SetAgentHelp callsites + agentAwareHelpFunc / SetHelpFunc wiring in cmd/root.go - Migrate 4 command-level rules to standard Long help (visible to all, not env-gated): doc upload mode mutex, kb edit at-least-one, kb pin idempotent, search chunks channel mutex - Rewrite AGENTS.md as a developer guide (gh-style 6 H2 / 167 lines): audience preamble + Build / Architecture / Command Structure / Testing / Code Style / Error Handling. Drops sections absent in surveyed projects (Commit & PR Conventions, Who Uses This CLI) - Clean 14 internal doc refs (ADR-N, spec §X, v0.X) in source comments and docs that pointed at docs/superpowers/ — that directory is local-only / uncommitted, so refs are dead for outside readers - Drop forward-looking "once v0.2 ships" from README
51 lines
1.4 KiB
Go
51 lines
1.4 KiB
Go
package search
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
|
|
"github.com/Tencent/WeKnora/cli/internal/iostreams"
|
|
)
|
|
|
|
// TestSearch_NoArgs_ShowsHelp: bare `weknora search` (no subcommand)
|
|
// must run cobra's Help() without erroring.
|
|
func TestSearch_NoArgs_ShowsHelp(t *testing.T) {
|
|
_, _ = iostreams.SetForTest(t)
|
|
cmd := NewCmdSearch(&cmdutil.Factory{})
|
|
cmd.SetArgs([]string{})
|
|
cmd.SilenceErrors = true
|
|
cmd.SilenceUsage = true
|
|
require.NoError(t, cmd.Execute())
|
|
}
|
|
|
|
// TestSearch_RejectsPositional: bare positional `weknora search "<q>" --kb X`
|
|
// must error - search is a pure dispatcher with no shortcut form.
|
|
func TestSearch_RejectsPositional(t *testing.T) {
|
|
_, _ = iostreams.SetForTest(t)
|
|
cmd := NewCmdSearch(&cmdutil.Factory{})
|
|
cmd.SetArgs([]string{"hello", "--kb", "kb_abc"})
|
|
cmd.SilenceErrors = true
|
|
cmd.SilenceUsage = true
|
|
err := cmd.Execute()
|
|
require.Error(t, err)
|
|
}
|
|
|
|
// TestSearch_SubcommandsRegistered: ensure chunks/kb/docs/sessions are
|
|
// reachable through the parent. Smoke-test only; the subcommands' own
|
|
// tests cover behavior.
|
|
func TestSearch_SubcommandsRegistered(t *testing.T) {
|
|
f := &cmdutil.Factory{}
|
|
cmd := NewCmdSearch(f)
|
|
names := map[string]bool{}
|
|
for _, c := range cmd.Commands() {
|
|
names[c.Name()] = true
|
|
}
|
|
for _, want := range []string{"chunks", "kb", "docs", "sessions"} {
|
|
if !names[want] {
|
|
t.Errorf("missing subcommand %q", want)
|
|
}
|
|
}
|
|
}
|