mirror of
https://github.com/Tencent/WeKnora.git
synced 2026-09-01 14:53:07 +08:00
34bb0b5096
Batch-write surface and pagination consistency:
* weknora doc delete <doc-id> [<doc-id>...] — positional multi-id, default
keep-going on failure. Single -y confirms entire batch.
* weknora session delete <session-id> [<session-id>...] — same shape.
* weknora chunk delete <chunk-id> [<chunk-id>...] --doc <doc-id> — multi-id
with shared --doc parent.
* Multi-id partial-failure rolls up as operation.failed (exit 1), not
server.error (exit 7) — failures are operation outcomes, not transient
transport issues, and the retry-with-backoff hint for server.* would
mislead callers.
* weknora api <path> --paginate — auto-walks offset pagination and merges
pages into a single {data, total} JSON response.
* Paginate truncation fix across 6 list/follower call sites.
* All doc / search / chunk / session / kb list commands migrated to
FormatOptions API.
Multi-id RunE only emits the {ok, failed} envelope when the operation
actually ran — pre-flight failures (e.g. confirmation_required) leave
stdout empty per the wire contract.
doc upload's missing-positional-or-flag check is wrapped as FlagError so
the exit code (2) matches the convention used by other commands that
require a positional argument directly.
161 lines
5.6 KiB
Go
161 lines
5.6 KiB
Go
package sessioncmd
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"io"
|
|
|
|
"github.com/spf13/cobra"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
|
|
"github.com/Tencent/WeKnora/cli/internal/iostreams"
|
|
"github.com/Tencent/WeKnora/cli/internal/prompt"
|
|
)
|
|
|
|
// sessionDeleteFields enumerates the fields surfaced for `--format json`
|
|
// discovery on `session delete`. Tracks the single-id result struct;
|
|
// multi-id mode emits MultiDeleteResult (ok/failed).
|
|
var sessionDeleteFields = []string{"id", "deleted"}
|
|
|
|
type DeleteOptions struct {
|
|
Yes bool // sourced from the global -y/--yes persistent flag
|
|
}
|
|
|
|
// DeleteService is the narrow SDK surface this command depends on.
|
|
type DeleteService interface {
|
|
DeleteSession(ctx context.Context, id string) error
|
|
}
|
|
|
|
// deleteResult is the typed payload emitted under data on single-id success.
|
|
type deleteResult struct {
|
|
ID string `json:"id"`
|
|
Deleted bool `json:"deleted"`
|
|
}
|
|
|
|
// MultiDeleteResult is the payload for multi-id deletes.
|
|
// ok: ids successfully deleted; failed: ids that could not be deleted.
|
|
type MultiDeleteResult struct {
|
|
OK []string `json:"ok"`
|
|
Failed []FailedItem `json:"failed,omitempty"`
|
|
}
|
|
|
|
// FailedItem records an id that failed to delete along with its error message.
|
|
type FailedItem struct {
|
|
ID string `json:"id"`
|
|
Code string `json:"code,omitempty"`
|
|
Message string `json:"message"`
|
|
}
|
|
|
|
// NewCmdDelete builds `weknora session delete`. Single-id keeps the simpler
|
|
// code path; multi-id uses keep-going semantics (one -y confirms all,
|
|
// failures collected, exit 1 if any fail).
|
|
func NewCmdDelete(f *cmdutil.Factory) *cobra.Command {
|
|
opts := &DeleteOptions{}
|
|
cmd := &cobra.Command{
|
|
Use: "delete <session-id> [<session-id>...]",
|
|
Short: "Delete one or more chat sessions",
|
|
Long: `Permanently delete one or more chat sessions and their messages.
|
|
|
|
Prompts for confirmation by default when stdout is a TTY and JSON output is
|
|
not set. Pass -y/--yes (global flag) to skip the prompt (required in agent
|
|
/ CI / piped contexts).
|
|
|
|
Single-id: one confirm prompt, exit 0/1.
|
|
Multi-id:
|
|
• Default keep-going: failed deletes do NOT stop the run; failures collected.
|
|
• One -y/--yes confirms all sessions.
|
|
• Exit 0 if all succeed; exit 1 if any failed.
|
|
|
|
AI agents: This is a high-risk write. Without -y/--yes the CLI exits 10
|
|
and writes input.confirmation_required to stderr. NEVER auto-pass -y
|
|
without the user's explicit go-ahead.`,
|
|
Example: ` weknora session delete s_abc # interactive confirm
|
|
weknora session delete s_abc -y # no prompt
|
|
weknora session delete s_abc -y --format json # bare {id, deleted:true} JSON
|
|
weknora session delete s_a s_b s_c -y # delete 3, keep-going`,
|
|
Args: cobra.MinimumNArgs(1),
|
|
RunE: func(c *cobra.Command, args []string) error {
|
|
opts.Yes, _ = c.Flags().GetBool("yes")
|
|
fopts, err := cmdutil.CheckFormatFlag(c)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
fopts.ResolveDefault(iostreams.IO.IsStdoutTTY())
|
|
cli, err := f.Client()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
// Single-id uses the simpler code path (bare {id, deleted}).
|
|
if len(args) == 1 {
|
|
return runDelete(c.Context(), opts, fopts, cli, f.Prompter(), args[0])
|
|
}
|
|
res, runErr := runMultiDelete(c.Context(), opts, fopts, cli, f.Prompter(), args)
|
|
// Only emit when the operation actually ran. Pre-flight errors
|
|
// (e.g. confirmation_required) must leave stdout empty per the
|
|
// wire contract in README.md.
|
|
if len(res.OK) > 0 || len(res.Failed) > 0 {
|
|
if emitErr := emitMultiDelete(res, fopts, iostreams.IO.Out); emitErr != nil {
|
|
return emitErr
|
|
}
|
|
}
|
|
return runErr
|
|
},
|
|
}
|
|
cmdutil.AddFormatFlag(cmd, sessionDeleteFields...)
|
|
return cmd
|
|
}
|
|
|
|
func runDelete(ctx context.Context, opts *DeleteOptions, fopts *cmdutil.FormatOptions, svc DeleteService, p prompt.Prompter, id string) error {
|
|
if err := cmdutil.ConfirmDestructive(p, opts.Yes, fopts.WantsJSON(), "session", id); err != nil {
|
|
return err
|
|
}
|
|
|
|
if err := svc.DeleteSession(ctx, id); err != nil {
|
|
return cmdutil.WrapHTTP(err, "delete session %s", id)
|
|
}
|
|
|
|
if fopts.WantsJSON() {
|
|
return fopts.Emit(iostreams.IO.Out, deleteResult{ID: id, Deleted: true})
|
|
}
|
|
fmt.Fprintf(iostreams.IO.Out, "✓ Deleted session %s\n", id)
|
|
return nil
|
|
}
|
|
|
|
// runMultiDelete iterates ids sequentially, keep-going on error: a single
|
|
// failure does not abort the run, so the caller sees the full outcome.
|
|
func runMultiDelete(ctx context.Context, opts *DeleteOptions, fopts *cmdutil.FormatOptions, svc DeleteService, p prompt.Prompter, ids []string) (*MultiDeleteResult, error) {
|
|
if err := cmdutil.ConfirmDestructiveBatch(p, opts.Yes, fopts.WantsJSON(), "session", len(ids)); err != nil {
|
|
return &MultiDeleteResult{}, err
|
|
}
|
|
res := &MultiDeleteResult{}
|
|
for _, id := range ids {
|
|
if err := svc.DeleteSession(ctx, id); err != nil {
|
|
res.Failed = append(res.Failed, FailedItem{ID: id, Message: err.Error()})
|
|
continue
|
|
}
|
|
res.OK = append(res.OK, id)
|
|
}
|
|
if len(res.Failed) > 0 {
|
|
return res, cmdutil.NewError(cmdutil.CodeOperationFailed, fmt.Sprintf("%d/%d delete(s) failed", len(res.Failed), len(ids)))
|
|
}
|
|
return res, nil
|
|
}
|
|
|
|
// emitMultiDelete renders per --format. Mirrors doc delete emitMultiDelete.
|
|
func emitMultiDelete(res *MultiDeleteResult, fopts *cmdutil.FormatOptions, w io.Writer) error {
|
|
switch fopts.Mode {
|
|
case cmdutil.FormatJSON, cmdutil.FormatNDJSON:
|
|
return fopts.Emit(w, res)
|
|
case cmdutil.FormatText, "":
|
|
for _, id := range res.OK {
|
|
fmt.Fprintf(w, "OK %s\n", id)
|
|
}
|
|
for _, f := range res.Failed {
|
|
fmt.Fprintf(w, "FAIL %s: %s\n", f.ID, f.Message)
|
|
}
|
|
return nil
|
|
default:
|
|
return fmt.Errorf("unsupported --format %q for session delete", fopts.Mode)
|
|
}
|
|
}
|