mirror of
https://github.com/Tencent/WeKnora.git
synced 2026-11-02 13:12:00 +08:00
Post-review polish on the v0.7 wire / surface contract. Bundles five
follow-ups that landed after the main BREAKING feat commit:
1. Complete context→profile cascade (internal API + YAML schema)
The prior commit renamed only the user-visible surface (commands /
flags / env / project link / envelope field). The internal Go API
and on-disk config schema were still half-renamed — an L-25
self-consistency violation flagged by post-merge review. Closed here:
Internal Go API:
- config.Context → config.Profile
- config.Config.CurrentContext → CurrentProfile
- config.Config.Contexts → Profiles
- LoginOptions.Context → LoginOptions.Profile
- clearContextSecrets() → clearProfileSecrets()
- saveContextRef() → saveProfileRef()
- secrets.Store: param name `context` → `profile` (interface +
FileStore + KeyringStore + MemStore)
- cmdutil.LoadSecret(store, context, key) → LoadSecret(store, profile, key)
- cmdutil.RefreshAndPersist's ctxName → profileName
- Local var `ctx := &config.Profile{...}` → `prof := &config.Profile{...}`
in auth/login.go to eliminate the visual collision with Go stdlib
context.Context that motivated the whole rename in the first place.
On-disk config.yaml schema:
- current_context: → current_profile:
- contexts: → profiles:
- Pre-1.0 break, no compat alias. Users on v0.6 dogfooded configs
must delete ~/.config/weknora/config.yaml or hand-rename the two
keys (CHANGELOG migration note added).
Tests / fixtures / golden files:
- factory_test.go YAML fixture + assertion updated.
- acceptance/e2e/e2e_test.go writeContextYAML → writeProfileYAML,
fixture YAML keys updated.
- acceptance/testdata/wire/doctor.error_network.json golden updated
("active context" → "active profile" in hint string).
User-visible prose sweep:
- cmd/mcp/serve.go --help Long: "active context (or --context)" →
"active profile (or --profile)" — most-visible miss.
- cmd/{kb/list, search/kb, session/list, api/api} Short/Long help.
- cmd/auth/login.go stdout: `(context=%s)` → `(profile=%s)`.
- cmd/auth/logout.go error: `"no current context"` → `"no current profile"`.
- cmd/doctor/doctor.go hint string (also the wire golden above).
- cmd/auth/refresh.go error: `"refresh token missing for context"` →
`"refresh token missing for profile"`.
- README.md: `## Multi-context` H2 → `## Multi-profile`; code-block
comment `# current context` → `# current profile`.
Code-comment / docstring sweep across cli/cmd/auth/ and
cli/internal/cmdutil/. Comments referencing Go stdlib context.Context,
the RAG / LLM "context window" concept, and historical CHANGELOG
entries for v0.4 / v0.5 were left alone.
CHANGELOG v0.7 BREAKING entry gains the on-disk-schema bullet under
the existing "context → profile" item.
2. Profile name validation (shell-injection guard)
`envelope.error.retry_command` is a single shell-string field. An
AI agent that exec()s it via `sh -c <retry_command>` was injectable
through a maliciously-named profile:
weknora auth logout --name 'x; rm -rf ~'
# would produce: retry_command = "weknora auth logout --name x; rm -rf ~ -y"
`cmd/profile/add.go` already enforced an alphanumeric + `-_.`
allowlist via `validateName`. The `auth login` and `auth logout`
paths bypassed it.
- Moved validation from `cmd/profile/add.go` to
`cli/internal/cmdutil/profilename.go` as exported
`ValidateProfileName` (cmdutil is the import-cycle-safe home;
internal/config can't depend on cmdutil).
- `auth login` runs the validator before any persist call.
- `auth logout` runs the validator on `opts.Name` before
constructing `retry_command`.
- Unit tests (`profilename_test.go`) cover the allowlist, empty
rejection, path-traversal, shell metacharacters (`;`, `&`, `|`,
`$()`, backticks, quotes, whitespace, glob, redirects), and the
user-facing hint text. The shell-metachar test exists as a
regression guard.
Wire shape (`retry_command` string → `retry_command_argv []string`)
remains a v0.8 additive change per ROADMAP — this fix removes the
practical exploit path without touching the wire contract.
3. AI-agent terminology disambiguation
"agent" has three referents in this codebase: (a) WeKnora's
server-side Custom Agent resource, (b) the removed `agent invoke`
verb, (c) external LLM/automation consumers. Per project memory
feedback_no_meta_disambiguation_in_docs, the fix is full-term
naming, not "X has N meanings" prose. Surgical changes at section
headers + ambiguous prose:
- AGENTS.md: "Agent decision shortcuts" → "AI agent decision
shortcuts"; "agent-callable surface" → "AI-agent-callable
surface".
- README.md: "Designed to be agent-first" → "AI-agent-first";
"Other agent ergonomics" → "Other AI-agent ergonomics"; "in
agent contexts" → "in AI-agent contexts"; "for CI / agents" →
"for CI / AI agents".
Anaphoric "agents" inside paragraphs that already established
"AI agents" was left alone — full substitution everywhere would
have been prose noise without clarity gain.
4. Wire-contract review follow-ups
Real findings from a second-pass review of the v0.7 envelope /
streaming / surface design. Per project memory
feedback_check_in_domain_anchor_first, candidate findings were
first verified against the in-domain peer CLI explicitly cited as
the envelope anchor; two earlier-flagged issues turned out to be
in-pattern and were withdrawn.
Surviving fixes:
- AGENTS.md success-envelope example rewritten. The prior example
showed `has_more: false` / `_notice: {}` as if they were always
present, but both fields are `omitempty` and never serialize
when zero / nil. Replaced with three realistic shapes (list /
single resource / mutation with no payload) and added a note
that optional fields are omitted when empty.
- cmd/chat/chat.go Args: MinimumNArgs(1) → ExactArgs(1).
v0.6 silently joined `weknora chat hello world` into
`"hello world"`. v0.7 now rejects multi-arg with exit 2,
matching `weknora session ask`. BREAKING; CHANGELOG entry
added under v0.7 BREAKING.
- internal/output/envelope.go extracts NewEnvelope(data, meta,
profile) constructor. The jq-filter path in
cmdutil.FormatOptions.Emit was manually rebuilding the
envelope literal alongside the canonical WriteEnvelope path —
drift risk when fields are added. Single construction point now.
- internal/cmdutil/factory.go adds AddKBFlag(cmd) helper.
Five files (chat, doc/list, doc/upload, doc/create, doc/fetch)
had verbatim-identical `cmd.Flags().String("kb", ...)`
declarations. Centralised so flag name + help text stay
in sync with Factory.ResolveKB. Docstring reordering + gofmt
fixup landed in the same edit to keep ResolveKB's own godoc
attached to its function.
5. OSS-readiness comment / doc sweep
Pre-publication scrub of code, comments, and shipped Markdown to
remove references that only make sense in the development repo:
- AGENTS.md "Deliberate deviations + mainstream alignments"
section: removed peer-project name-drops from the comparison
table; rewrote as five flagged design decisions with rationale
but no specific competitor named. The four rows that previously
contrasted against a named peer CLI now state WeKnora's choice
+ rationale directly. Section header renamed to "Design
decisions worth flagging" since it is no longer a
deviation/alignment matrix.
- CHANGELOG v0.7 BREAKING rationales: three references to a
named peer CLI removed; the context→profile rationale now
cites only mainstream multi-credential CLIs by category (AWS /
Stripe / OpenAI / Anthropic), and the `api -d/--data` removal
rationale cites only `gh api` / `curl`. `chat` BREAKING entry
rationale similarly simplified.
- 35 cross-references to design-spec section numbers (§4.1 /
§4.5 / §5.3 etc.) removed from Go doc comments and test
comments across 13 files. The referenced spec lives outside
the shipped tree; readers of the public repo cannot resolve
them. Each reference replaced with a self-contained semantic
description (e.g. "the batch envelope" / "AGENTS.md section
on the success path").
- Mixed-language strings translated to English:
- Four Go comments: internal/cmdutil/exit.go:213,215,
internal/cmdutil/errors.go:156,
internal/output/batch_test.go:90,
internal/output/envelope_test.go:27.
- One CHANGELOG section title:
`v0.7 — Agent-first wire contract + 命令面集中清理` →
`... + command-surface cleanup`.
- CJK test fixtures (internal/text/truncate_test.go CJK
truncation cases, cmd/session/list_test.go Chinese session
title, acceptance/e2e/e2e_test.go Chinese RAG corpus)
retained — they are intentional test inputs, not stray prose.
- Makefile help comment: `golangci-lint added in PR-9` →
`golangci-lint planned`. Internal PR numbering should not
surface in shipped Makefile prose.
Build green, 28/28 packages, +5 new ValidateProfileName tests.
go vet / gofmt / go mod verify / go mod tidy all clean.
Rationale for the cascade: pre-1.0 is the cheapest moment to close
L-25 self-consistency (L-26). The half-finished internal rename
would have perpetuated the very `context` vs `context.Context`
ambiguity that motivated v0.7's user-visible rename in the first
place.
374 lines
13 KiB
Go
374 lines
13 KiB
Go
// Package api implements the `weknora api` raw HTTP passthrough command.
|
|
//
|
|
// Shape: one positional (path) + `-X/--method` flag, default GET (auto-
|
|
// promoted to POST when a body is supplied via --input). Default raw
|
|
// response body to stdout; --format json emits a {status, headers, body}
|
|
// object. Reuses sdk.Client.Raw which already applies tenant + auth headers.
|
|
package api
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
"io"
|
|
"net/http"
|
|
"net/url"
|
|
"os"
|
|
"strconv"
|
|
"strings"
|
|
|
|
"github.com/spf13/cobra"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
|
|
"github.com/Tencent/WeKnora/cli/internal/iostreams"
|
|
sdk "github.com/Tencent/WeKnora/client"
|
|
)
|
|
|
|
// apiFields is intentionally a marker - api wraps arbitrary HTTP responses
|
|
// whose schema the CLI doesn't know, so field hints are meaningless here.
|
|
// The marker shows up in --help so users can tell.
|
|
var apiFields = []string{"<response-shape-varies>"}
|
|
|
|
type Options struct {
|
|
Method string
|
|
Input string // --input: file path, "-" for stdin
|
|
Yes bool
|
|
StdinReader io.Reader // overridden by tests; defaults to iostreams.IO.In
|
|
}
|
|
|
|
// Service is the narrow SDK surface this command depends on. The production
|
|
// implementation is *sdk.Client, whose Raw method already injects auth /
|
|
// tenant / request-id headers (see client.applyAuthHeaders). Tests substitute
|
|
// either a fake or a real client pointed at httptest.Server.
|
|
type Service interface {
|
|
Raw(ctx context.Context, method, path string, body any) (*http.Response, error)
|
|
}
|
|
|
|
// NewCmd returns the `weknora api` command.
|
|
func NewCmd(f *cmdutil.Factory) *cobra.Command {
|
|
opts := &Options{}
|
|
cmd := &cobra.Command{
|
|
Use: "api <path>",
|
|
Short: "Make a raw API request to the WeKnora server",
|
|
Long: `Raw HTTP API access. Body via --input <file> or --input - (stdin).
|
|
|
|
The default method is GET; passing --input auto-promotes it to POST. Use
|
|
-X/--method to override (any non-empty method is accepted: DELETE / PUT /
|
|
PATCH / HEAD / OPTIONS / TRACE / custom).
|
|
|
|
Auth, tenant, and request-id headers are applied automatically from the
|
|
active profile. The response body is written to stdout by default; use
|
|
--format json to emit a {status, headers, body} envelope.
|
|
|
|
Examples:
|
|
weknora api /api/v1/knowledge-bases # GET
|
|
echo '{"name":"foo"}' | weknora api /api/v1/knowledge-bases --input - # POST (auto)
|
|
weknora api /api/v1/knowledge-bases/kb_xxx -X DELETE`,
|
|
Args: cobra.ExactArgs(1),
|
|
RunE: func(c *cobra.Command, args []string) error {
|
|
opts.Yes, _ = c.Flags().GetBool("yes")
|
|
fopts, err := cmdutil.CheckFormatFlag(c)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
fopts.ResolveDefault(iostreams.IO.IsStdoutTTY())
|
|
method := resolveMethod(opts)
|
|
// Escape-hatch DELETE through `weknora api` is just as destructive
|
|
// as `weknora kb delete` - exit-10 protocol must apply (cli/README.md).
|
|
if method == http.MethodDelete {
|
|
if err := cmdutil.ConfirmDestructive(f.Prompter(), opts.Yes, fopts.WantsJSON(), "endpoint", args[0], "api.delete", "weknora api -X DELETE "+args[0]+" -y"); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
cli, err := f.Client()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
paginate, _ := c.Flags().GetBool("paginate")
|
|
return runAPI(c.Context(), opts, fopts, cli, method, args[0], paginate)
|
|
},
|
|
}
|
|
cmd.Flags().StringVarP(&opts.Method, "method", "X", "", "HTTP method (default: GET, or POST when --input is supplied). Any non-empty method is accepted.")
|
|
cmd.Flags().StringVar(&opts.Input, "input", "", "Read request body from file (use `-` for stdin)")
|
|
cmd.Flags().Bool("paginate", false, "Follow offset-based pagination (?page=N&page_size=M), merging all pages into a single {data, total} JSON response.")
|
|
cmdutil.AddFormatFlag(cmd, apiFields...)
|
|
return cmd
|
|
}
|
|
|
|
// readInput reads opts.Input and returns its contents. "-" reads from
|
|
// opts.StdinReader (or iostreams.IO.In as the production default) for
|
|
// piped JSON payloads.
|
|
func readInput(opts *Options) ([]byte, error) {
|
|
if opts.Input == "-" {
|
|
r := opts.StdinReader
|
|
if r == nil {
|
|
r = iostreams.IO.In
|
|
}
|
|
b, err := io.ReadAll(r)
|
|
if err != nil {
|
|
return nil, cmdutil.Wrapf(cmdutil.CodeLocalFileIO, err, "read request body from stdin")
|
|
}
|
|
return b, nil
|
|
}
|
|
b, err := os.ReadFile(opts.Input)
|
|
if err != nil {
|
|
return nil, cmdutil.Wrapf(cmdutil.CodeLocalFileIO, err, "read input file %s", opts.Input)
|
|
}
|
|
return b, nil
|
|
}
|
|
|
|
// resolveMethod implements the auto-method behavior: explicit -X wins;
|
|
// otherwise body presence promotes GET → POST.
|
|
func resolveMethod(opts *Options) string {
|
|
if opts.Method != "" {
|
|
return strings.ToUpper(opts.Method)
|
|
}
|
|
if opts.Input != "" {
|
|
return "POST"
|
|
}
|
|
return "GET"
|
|
}
|
|
|
|
// runAPI is the testable core: validate inputs, dispatch via Service.Raw,
|
|
// classify status, and emit either the raw body or a JSON object. The
|
|
// caller is responsible for resolving the method (defaults / auto-POST)
|
|
// and uppercasing it; runAPI guards against unsupported values like
|
|
// `-X PATCH-INVALID` reaching the wire.
|
|
//
|
|
// When paginate is true and method is GET, all offset-based pages are
|
|
// fetched and merged into a single {data, total} JSON response. For
|
|
// non-GET methods paginate is silently ignored (no offset semantic).
|
|
func runAPI(ctx context.Context, opts *Options, fopts *cmdutil.FormatOptions, svc Service, method, path string, paginate bool) error {
|
|
if paginate && method == http.MethodGet {
|
|
return runAPIPaginated(ctx, opts, fopts, svc, path)
|
|
}
|
|
return runAPISingle(ctx, opts, fopts, svc, method, path)
|
|
}
|
|
|
|
// runAPISingle is the original single-call implementation of runAPI.
|
|
func runAPISingle(ctx context.Context, opts *Options, fopts *cmdutil.FormatOptions, svc Service, method, path string) error {
|
|
if method == "" {
|
|
return cmdutil.NewFlagError(fmt.Errorf("--method cannot be empty"))
|
|
}
|
|
if !strings.HasPrefix(path, "/") {
|
|
return cmdutil.NewError(cmdutil.CodeInputInvalidArgument, fmt.Sprintf("path must start with /: %s", path))
|
|
}
|
|
|
|
// Resolve request body from --input (file path or `-` for stdin).
|
|
var body any
|
|
if opts.Input != "" {
|
|
contents, err := readInput(opts)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
body = json.RawMessage(contents)
|
|
}
|
|
|
|
resp, err := svc.Raw(ctx, method, path, body)
|
|
if err != nil {
|
|
// Transport / DNS failure (Raw never returns a typed HTTP error of its
|
|
// own; non-2xx responses still surface as resp != nil, err == nil).
|
|
return cmdutil.WrapHTTP(err, "%s %s", method, path)
|
|
}
|
|
defer resp.Body.Close()
|
|
|
|
respBody, err := io.ReadAll(resp.Body)
|
|
if err != nil {
|
|
return cmdutil.Wrapf(cmdutil.CodeNetworkError, err, "read response body")
|
|
}
|
|
|
|
if resp.StatusCode < 200 || resp.StatusCode >= 300 {
|
|
code := cmdutil.ClassifyHTTPStatus(resp.StatusCode)
|
|
ce := cmdutil.NewError(code, fmt.Sprintf("HTTP %d: %s", resp.StatusCode, strings.TrimSpace(string(respBody))))
|
|
if v := resp.Header.Get("Retry-After"); v != "" {
|
|
if s, perr := strconv.Atoi(v); perr == nil && s > 0 {
|
|
ce = ce.WithRetryAfter(s)
|
|
}
|
|
}
|
|
return ce
|
|
}
|
|
|
|
out := iostreams.IO.Out
|
|
if fopts.WantsJSON() {
|
|
// Best-effort decode: if response body is valid JSON, surface the
|
|
// parsed structure under .body so JSON consumers can drill
|
|
// in; otherwise fall back to the raw string.
|
|
var bodyAny any
|
|
if len(respBody) > 0 {
|
|
if err := json.Unmarshal(respBody, &bodyAny); err != nil {
|
|
bodyAny = string(respBody)
|
|
}
|
|
}
|
|
hdrs := make(map[string]string, len(resp.Header))
|
|
for k, v := range resp.Header {
|
|
if len(v) > 0 {
|
|
hdrs[k] = v[0]
|
|
}
|
|
}
|
|
// Route through fopts.Emit so the payload lives under .data in the
|
|
// success envelope. --jq applies to the full envelope, so users
|
|
// project with ".data.status", ".data.body", etc.
|
|
payload := map[string]any{
|
|
"status": resp.StatusCode,
|
|
"headers": hdrs,
|
|
"body": bodyAny,
|
|
}
|
|
return fopts.Emit(out, payload, nil)
|
|
}
|
|
|
|
if _, err := out.Write(respBody); err != nil {
|
|
return cmdutil.Wrapf(cmdutil.CodeLocalFileIO, err, "write response body")
|
|
}
|
|
if len(respBody) > 0 && respBody[len(respBody)-1] != '\n' {
|
|
_, _ = out.Write([]byte{'\n'})
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// runAPIPaginated fetches all offset-based pages for a GET request and writes
|
|
// a single merged {data, total} JSON object to stdout. If the first page
|
|
// response does not carry pagination metadata (total + page_size), the raw
|
|
// response is passed through via passThroughFallback which respects the
|
|
// --format envelope contract (same shape as runAPISingle's fallback path).
|
|
func runAPIPaginated(ctx context.Context, opts *Options, fopts *cmdutil.FormatOptions, svc Service, path string) error {
|
|
if !strings.HasPrefix(path, "/") {
|
|
return cmdutil.NewError(cmdutil.CodeInputInvalidArgument, fmt.Sprintf("path must start with /: %s", path))
|
|
}
|
|
|
|
pageSize := extractPageSize(path)
|
|
if pageSize == 0 {
|
|
pageSize = 50
|
|
}
|
|
|
|
allData := []json.RawMessage{}
|
|
var lastTotal int64
|
|
page := 1
|
|
|
|
for {
|
|
curPath := setPageParam(path, page, pageSize)
|
|
resp, err := svc.Raw(ctx, http.MethodGet, curPath, nil)
|
|
if err != nil {
|
|
return cmdutil.WrapHTTP(err, "GET %s", curPath)
|
|
}
|
|
body, _ := io.ReadAll(resp.Body)
|
|
resp.Body.Close()
|
|
|
|
if resp.StatusCode < 200 || resp.StatusCode >= 300 {
|
|
code := cmdutil.ClassifyHTTPStatus(resp.StatusCode)
|
|
return cmdutil.NewError(code, fmt.Sprintf("HTTP %d: %s", resp.StatusCode, strings.TrimSpace(string(body))))
|
|
}
|
|
|
|
var pageResp struct {
|
|
Data []json.RawMessage `json:"data"`
|
|
Total int64 `json:"total"`
|
|
Page int `json:"page"`
|
|
PageSize int `json:"page_size"`
|
|
}
|
|
if err := json.Unmarshal(body, &pageResp); err != nil {
|
|
// Non-JSON response on first page — fall back through the envelope.
|
|
if page == 1 {
|
|
return passThroughFallback(body, resp, fopts)
|
|
}
|
|
return cmdutil.NewError(cmdutil.CodeInputInvalidArgument,
|
|
fmt.Sprintf("--paginate: page %d response not in expected shape: %v", page, err))
|
|
}
|
|
|
|
// Heuristic: if the first page lacks pagination metadata, treat the
|
|
// response as non-paginated and fall back through the envelope.
|
|
if page == 1 && pageResp.Total == 0 && pageResp.PageSize == 0 {
|
|
return passThroughFallback(body, resp, fopts)
|
|
}
|
|
|
|
allData = append(allData, pageResp.Data...)
|
|
lastTotal = pageResp.Total
|
|
|
|
// Termination: accumulated count (not page*pageSize) handles server-capped page sizes.
|
|
if int64(len(allData)) >= pageResp.Total || len(pageResp.Data) == 0 {
|
|
break
|
|
}
|
|
page++
|
|
}
|
|
|
|
merged := map[string]any{
|
|
"data": allData,
|
|
"total": lastTotal,
|
|
}
|
|
return fopts.Emit(iostreams.IO.Out, merged, nil)
|
|
}
|
|
|
|
// passThroughFallback handles the case where --paginate detects a
|
|
// non-paginated first-page response. When JSON output is requested, it routes
|
|
// the body through fopts.Emit in the same {status, headers, body} envelope
|
|
// shape that runAPISingle produces — keeping the wire contract consistent
|
|
// regardless of whether --paginate was passed. For human-readable mode it
|
|
// writes the raw body verbatim (same as the original passThroughRaw behavior).
|
|
func passThroughFallback(body []byte, resp *http.Response, fopts *cmdutil.FormatOptions) error {
|
|
out := iostreams.IO.Out
|
|
if fopts.WantsJSON() {
|
|
var bodyAny any
|
|
if len(body) > 0 {
|
|
if err := json.Unmarshal(body, &bodyAny); err != nil {
|
|
bodyAny = string(body) // best-effort string fallback
|
|
}
|
|
}
|
|
hdrs := collectHeaders(resp)
|
|
return fopts.Emit(out, map[string]any{
|
|
"status": resp.StatusCode,
|
|
"headers": hdrs,
|
|
"body": bodyAny,
|
|
}, nil)
|
|
}
|
|
// Human-readable: raw passthrough, same as before.
|
|
if _, err := out.Write(body); err != nil {
|
|
return cmdutil.Wrapf(cmdutil.CodeLocalFileIO, err, "write response body")
|
|
}
|
|
if len(body) > 0 && body[len(body)-1] != '\n' {
|
|
_, _ = out.Write([]byte{'\n'})
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// collectHeaders extracts the first value of each response header into a flat
|
|
// map, matching the shape that runAPISingle emits in its JSON envelope.
|
|
func collectHeaders(resp *http.Response) map[string]string {
|
|
hdrs := make(map[string]string, len(resp.Header))
|
|
for k, v := range resp.Header {
|
|
if len(v) > 0 {
|
|
hdrs[k] = v[0]
|
|
}
|
|
}
|
|
return hdrs
|
|
}
|
|
|
|
// extractPageSize parses the page_size query parameter from path, returning 0
|
|
// if absent or unparseable.
|
|
func extractPageSize(path string) int {
|
|
u, err := url.Parse(path)
|
|
if err != nil {
|
|
return 0
|
|
}
|
|
if v := u.Query().Get("page_size"); v != "" {
|
|
if n, err := strconv.Atoi(v); err == nil && n > 0 {
|
|
return n
|
|
}
|
|
}
|
|
return 0
|
|
}
|
|
|
|
// setPageParam rewrites the page and page_size query parameters in path,
|
|
// preserving all other query parameters.
|
|
func setPageParam(path string, page, pageSize int) string {
|
|
u, err := url.Parse(path)
|
|
if err != nil {
|
|
return path
|
|
}
|
|
q := u.Query()
|
|
q.Set("page", strconv.Itoa(page))
|
|
q.Set("page_size", strconv.Itoa(pageSize))
|
|
u.RawQuery = q.Encode()
|
|
return u.String()
|
|
}
|
|
|
|
// compile-time check: the production SDK client implements Service.
|
|
var _ Service = (*sdk.Client)(nil)
|