mirror of
https://github.com/Tencent/WeKnora.git
synced 2026-09-01 14:53:07 +08:00
ochan.kwon
0e8de6192c
Wires KnowledgeBase.VectorStoreID and the ownership-aware retrieve factory into the user-facing knowledge-base lifecycle: - POST /knowledge-bases validates the requested vector_store_id against the caller's tenant scope and the engine registry. New error codes ErrVectorStoreBindingInvalid (2200) and ErrVectorStoreUnavailable (2201) distinguish the typed branches without echoing UUIDs to the client. - GET / POST / PUT / PUT-pin responses embed the bound store's display metadata (name, source, engine_type, status) without exposing any connection credentials. Cross-tenant shared KBs receive a suppressed payload (vector_store_id stripped, source="shared") so operator-chosen store names cannot be enumerated across tenants. - POST /knowledge-bases/copy synchronously rejects clones whose target has a different embedding model or vector store, before the async clone task is enqueued. The async clone worker re-applies the same checks for defense in depth. - DELETE /vector-stores/:id refuses to remove a store with bound KBs, inside a transaction that row-locks the store on PostgreSQL and serializes via WAL on SQLite. unregister-from-registry is wrapped in defer/recover so a panic surfaces as a structured warning instead of silently leaking a stale engine. - vector_store_id is immutable after creation. The GORM <-:create tag blocks every ORM update path; the service-layer DTO omits the field entirely; a reflection-based regression test catches any future maintainer who adds it back to either layer. - Empty-string vector_store_id is normalized to nil at both the create path and inside SharesStoreWith, so rows persisted by callers that did not run Normalize first cannot trip false same-store comparisons. Part of #993. Depends on #994 and #1310.
65 lines
2.4 KiB
Go
65 lines
2.4 KiB
Go
package handler
|
|
|
|
import (
|
|
"reflect"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/Tencent/WeKnora/internal/types"
|
|
)
|
|
|
|
// TestUpdateKBRequest_DoesNotAcceptVectorStoreID is the structural enforcement
|
|
// behind the vector_store_id immutability contract. The GORM `<-:create`
|
|
// tag on KnowledgeBase.VectorStoreID already blocks every ORM UPDATE path
|
|
// (verified by the repository-level sqlite immutability tests), but the
|
|
// service DTO must independently refuse to even *accept* the field —
|
|
// otherwise a future maintainer who adds it to UpdateKnowledgeBaseRequest
|
|
// or KnowledgeBaseConfig opens a path where the field is silently ignored
|
|
// by the ORM, which is worse than an explicit rejection.
|
|
//
|
|
// This test walks the request and config struct shapes and fails if either
|
|
// gains a VectorStoreID member, by name or by JSON tag.
|
|
func TestUpdateKBRequest_DoesNotAcceptVectorStoreID(t *testing.T) {
|
|
t.Run("UpdateKnowledgeBaseRequest", func(t *testing.T) {
|
|
assertNoVectorStoreIDField(t, reflect.TypeOf(UpdateKnowledgeBaseRequest{}))
|
|
})
|
|
t.Run("KnowledgeBaseConfig", func(t *testing.T) {
|
|
// Config carries chunking / extract / faq / wiki sub-configs and must
|
|
// not be extended with a VectorStoreID either (Config is passed
|
|
// straight into the service Update path).
|
|
assertNoVectorStoreIDField(t, reflect.TypeOf(types.KnowledgeBaseConfig{}))
|
|
})
|
|
}
|
|
|
|
// assertNoVectorStoreIDField walks the visible fields of t (including embedded
|
|
// anonymous structs) and reports any field named VectorStoreID or carrying
|
|
// a json tag of "vector_store_id".
|
|
func assertNoVectorStoreIDField(t *testing.T, typ reflect.Type) {
|
|
t.Helper()
|
|
var visit func(rt reflect.Type, path string)
|
|
visit = func(rt reflect.Type, path string) {
|
|
for rt.Kind() == reflect.Ptr {
|
|
rt = rt.Elem()
|
|
}
|
|
if rt.Kind() != reflect.Struct {
|
|
return
|
|
}
|
|
for i := 0; i < rt.NumField(); i++ {
|
|
f := rt.Field(i)
|
|
full := path + "." + f.Name
|
|
if f.Name == "VectorStoreID" {
|
|
t.Fatalf("%s declares VectorStoreID — vector_store_id is immutable post-create "+
|
|
"and must not be accepted by update DTOs", full)
|
|
}
|
|
if tag := strings.Split(f.Tag.Get("json"), ",")[0]; tag == "vector_store_id" {
|
|
t.Fatalf("%s carries json tag \"vector_store_id\" — the field is immutable "+
|
|
"post-create and must not be accepted by update DTOs", full)
|
|
}
|
|
if f.Anonymous {
|
|
visit(f.Type, full)
|
|
}
|
|
}
|
|
}
|
|
visit(typ, typ.Name())
|
|
}
|