mirror of
https://github.com/Tencent/WeKnora.git
synced 2026-11-02 22:02:16 +08:00
ljl
2b31d3681b
If the embedding provider returns an empty slice of vectors (e.g. length 0) due to api mismatch or empty input, BatchEmbed will return length 0. Accessing embedding[i] directly in BatchEmbedWithPool results in an out of bounds panic. Because the panic occurs inside a mu.Lock() block, the mutex is never unlocked, leading to a permanent deadlock of the document processing queue. This fix checks the returned embeddings slice length and returns an error instead of panicking, releasing the mutex properly.
105 lines
2.3 KiB
Go
105 lines
2.3 KiB
Go
package embedding
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"os"
|
|
"strconv"
|
|
"sync"
|
|
|
|
"github.com/Tencent/WeKnora/internal/models/utils"
|
|
"github.com/panjf2000/ants/v2"
|
|
)
|
|
|
|
type batchEmbedder struct {
|
|
pool *ants.Pool
|
|
}
|
|
|
|
func NewBatchEmbedder(pool *ants.Pool) EmbedderPooler {
|
|
return &batchEmbedder{pool: pool}
|
|
}
|
|
|
|
type textEmbedding struct {
|
|
text string
|
|
results []float32
|
|
}
|
|
|
|
func (e *batchEmbedder) BatchEmbedWithPool(ctx context.Context, model Embedder, texts []string) ([][]float32, error) {
|
|
// Create goroutine pool for concurrent processing of document chunks
|
|
var wg sync.WaitGroup
|
|
var mu sync.Mutex // For synchronizing access to error
|
|
var firstErr error // Record the first error that occurs
|
|
batchSizeStr := os.Getenv("BATCH_EMBED_SIZE")
|
|
if batchSizeStr == "" {
|
|
batchSizeStr = "5"
|
|
}
|
|
batchSize, err := strconv.Atoi(batchSizeStr)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
textEmbeddings := utils.MapSlice(texts, func(text string) *textEmbedding {
|
|
return &textEmbedding{text: text}
|
|
})
|
|
|
|
// Function to process each document chunk
|
|
processChunk := func(texts []*textEmbedding) func() {
|
|
return func() {
|
|
defer wg.Done()
|
|
// If an error has already occurred, don't continue processing
|
|
if firstErr != nil {
|
|
return
|
|
}
|
|
// Embed text
|
|
embedding, err := model.BatchEmbed(ctx, utils.MapSlice(texts, func(text *textEmbedding) string {
|
|
return text.text
|
|
}))
|
|
if err != nil {
|
|
mu.Lock()
|
|
if firstErr == nil {
|
|
firstErr = err
|
|
}
|
|
mu.Unlock()
|
|
return
|
|
}
|
|
if len(embedding) != len(texts) {
|
|
mu.Lock()
|
|
if firstErr == nil {
|
|
firstErr = fmt.Errorf("embedding model returned %d embeddings for %d inputs", len(embedding), len(texts))
|
|
}
|
|
mu.Unlock()
|
|
return
|
|
}
|
|
mu.Lock()
|
|
for i, text := range texts {
|
|
if text == nil {
|
|
continue
|
|
}
|
|
text.results = embedding[i]
|
|
}
|
|
mu.Unlock()
|
|
}
|
|
}
|
|
|
|
// Submit all tasks to the goroutine pool
|
|
for _, texts := range utils.ChunkSlice(textEmbeddings, batchSize) {
|
|
wg.Add(1)
|
|
err := e.pool.Submit(processChunk(texts))
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
}
|
|
|
|
// Wait for all tasks to complete
|
|
wg.Wait()
|
|
|
|
// Check if any errors occurred
|
|
if firstErr != nil {
|
|
return nil, firstErr
|
|
}
|
|
|
|
results := utils.MapSlice(textEmbeddings, func(text *textEmbedding) []float32 {
|
|
return text.results
|
|
})
|
|
return results, nil
|
|
}
|