mirror of
https://github.com/Tencent/WeKnora.git
synced 2026-08-29 02:04:30 +08:00
d3c03b2f34
A hardening + finalization pass over the agent-first CLI: correctness fixes,
richer machine-readable signals, flag/naming consistency, and a symmetric
config surface. Pre-1.0, so it includes breaking renames.
Correctness:
- agent update: resolve/validate --model/--rerank-model (was storing a bogus
name verbatim, corrupting config.model_id).
- doctor: honor WEKNORA_HOST / WEKNORA_API_KEY (headless path no longer reports
"no host configured").
- session ask / MCP session_ask: text answer was empty on non-TTY — the agent
stream sets Done=true on an intermediate agent_query frame before the answer,
and AgentAccumulator treated the first Done as terminal. Terminate on the
`complete` event (new sdk.AgentResponseTypeComplete), not a per-frame Done.
- batch exit codes: any per-item failure collapses to operation.failed (exit 1),
including `doc upload --recursive` partial failures — a permanent per-file
failure (e.g. a duplicate) no longer surfaces as a retryable exit 7 an agent
would loop on; per-item typed errors stay in the envelope.
Agent-first signals & discovery:
- error.exit_code in the envelope (type + exit_code disambiguate the
input.invalid_argument exit-2-vs-5 split in one JSON read).
- meta.hint on empty content search and on draft doc create; doc wait fails fast
on a never-parsing draft instead of hanging to --timeout.
- retrieval-readiness is visible in the natural flow: kb status / kb check emit
retrieval_ready, and kb create hints the fix when no embedding model is bound
— an unconfigured KB no longer looks silently healthy.
- schema contract completeness: every leaf declares output + >=1 example
(drift-guarded); output strings match the meta actually emitted; chunk list
and search docs now emit meta.total_count (both previously dropped it).
- schema tolerates a quoted multi-word command label; zero-state auth — and
`link` with no profile — point at profile setup / the headless WEKNORA_KB_ID
path instead of looping on `auth login`.
- id-addressed reads tolerate a redundant --kb (doc view/wait, chunk list/view
accept and ignore it, declared in schema) so a carried-over --kb doesn't
exit 2; streaming commands warn that --jq does not apply to an NDJSON stream.
- keep JSON-always as the default; --jq hints spell out the .data path.
Consistency & gating:
- doc create: drop the deprecated --name alias (--title only; pre-1.0 break).
- chunk list --limit aligned to 1..10000; model list --limit/-L with
has_more/total_count; api write-gates -X PUT/PATCH (exit 10); skills install
expands a leading ~.
- docs corrected: search docs / doc list --keyword help is case-insensitive
(server does LOWER LIKE); AGENTS.md risk-action list (no phantom kb.init; add
model.update / kb.config.set) and batch example (failed item carries `error`);
session resume --message id comes from `message list`, not the stream.
- auth/profile ergonomics: env credentials are now first-class — `auth token`
prints the active WEKNORA_API_KEY / WEKNORA_TOKEN, and auth login/logout/refresh
give an env-aware message instead of looping on "run auth login". `auth logout`
clears credentials but keeps the profile registered (host preserved for
re-login); deleting a profile is `profile remove`'s job (clean logout/remove
separation, matching gh / lark).
Config surface (symmetric read/write, in-place model edits):
- kb config now returns a secret-free KBModelConfigView (was {}); `kb config`
reads, new `kb config set` writes; `kb init` removed (misnomer).
- kb create --chat-model: retrieval-ready in one step.
- model update: edit a model in place (id preserved, references survive) —
rotate --api-key-stdin, change base-url / display-name / etc.
- session continue-stream renamed to session resume.
Docs: AGENTS.md is the single wire-contract source; CHANGELOG slimmed; stale
kb-init / continue-stream references removed; skill wire-vocab guard extended.
AGENTS.md / weknora-shared SKILL document retrieval_ready (a KB needs an
embedding model to be searchable), that --jq does not apply to NDJSON
streams, and the env-credential-first auth path; the KB quickstart example
now creates a retrieval-ready KB.
122 lines
4.3 KiB
Go
122 lines
4.3 KiB
Go
package agentcmd
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
|
|
"github.com/spf13/cobra"
|
|
|
|
"github.com/Tencent/WeKnora/cli/internal/cmdutil"
|
|
"github.com/Tencent/WeKnora/cli/internal/iostreams"
|
|
"github.com/Tencent/WeKnora/cli/internal/prompt"
|
|
)
|
|
|
|
// agentDeleteFields enumerates the JSON discovery fields for `agent delete`.
|
|
// Result payload is a tiny {id, deleted} object — mirrors `kb delete`.
|
|
var agentDeleteFields = []string{"id", "deleted"}
|
|
|
|
type DeleteOptions struct {
|
|
AgentID string
|
|
Yes bool // sourced from the global -y/--yes persistent flag
|
|
DryRun bool
|
|
}
|
|
|
|
// DeleteService is the narrow SDK surface this command depends on.
|
|
type DeleteService interface {
|
|
DeleteAgent(ctx context.Context, id string) error
|
|
}
|
|
|
|
// deleteResult is the typed payload emitted on success in JSON mode.
|
|
type deleteResult struct {
|
|
ID string `json:"id"`
|
|
Deleted bool `json:"deleted"`
|
|
}
|
|
|
|
// Delete is NOT idempotent on a missing id — it surfaces resource.not_found
|
|
// rather than silently exiting 0. Idempotent-already-true semantics are
|
|
// reserved for unlink-style local cleanups, not server-side resource removal.
|
|
const agentDeleteLong = `Permanently delete a custom agent.
|
|
|
|
Prompts for confirmation by default when stdout is a TTY and --format json is
|
|
not set. Pass -y/--yes (the global flag) to skip the prompt (required in
|
|
agent / CI / piped contexts).
|
|
|
|
Typed exit codes:
|
|
resource.not_found no agent with the given id (exit 4)
|
|
auth.forbidden caller lacks delete permission on the agent (exit 3)
|
|
input.confirmation_required destructive op without -y on a TTY (exit 10)
|
|
|
|
AI agents: This is a high-risk write. Without -y/--yes the CLI exits 10
|
|
and writes input.confirmation_required to stderr. NEVER auto-pass -y
|
|
without the user's explicit go-ahead — the exit-10 protocol exists
|
|
exactly to guard against unintended deletes.`
|
|
|
|
const agentDeleteExample = ` weknora agent delete ag_abc # interactive confirm
|
|
weknora agent delete ag_abc -y # no prompt
|
|
weknora agent delete ag_abc -y --format json # bare {id, deleted:true} JSON`
|
|
|
|
// NewCmdDelete builds `weknora agent delete <agent-id>`.
|
|
func NewCmdDelete(f *cmdutil.Factory) *cobra.Command {
|
|
opts := &DeleteOptions{}
|
|
cmd := &cobra.Command{
|
|
Use: "delete <agent-id>",
|
|
Short: "Delete a custom agent",
|
|
Long: agentDeleteLong,
|
|
Example: agentDeleteExample,
|
|
Args: cobra.ExactArgs(1),
|
|
RunE: func(cmd *cobra.Command, args []string) error {
|
|
fopts, err := cmdutil.CheckFormatFlag(cmd)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
fopts.ResolveDefault(iostreams.IO.IsStdoutTTY())
|
|
opts.AgentID = args[0]
|
|
opts.Yes, _ = cmd.Flags().GetBool("yes")
|
|
if handled, err := cmdutil.HandleDryRun(cmd, opts.DryRun, cmdutil.DryRunPlan{
|
|
Action: "agent.delete",
|
|
Args: map[string]any{
|
|
"agent_id": opts.AgentID,
|
|
},
|
|
}); handled {
|
|
return err
|
|
}
|
|
cli, err := f.Client()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
return runDelete(cmd.Context(), opts, fopts, cli, f.Prompter())
|
|
},
|
|
}
|
|
cmdutil.AddFormatFlag(cmd, agentDeleteFields...)
|
|
cmdutil.AddDryRunFlag(cmd, &opts.DryRun)
|
|
cmdutil.SetRisk(cmd, "agent.delete")
|
|
cmdutil.SetAgentHelp(cmd, cmdutil.AgentHelp{
|
|
UsedFor: "permanently delete a custom agent",
|
|
RequiredFlags: []string{"<agent-id> (positional)"},
|
|
Output: "envelope.data is {id, deleted:true}",
|
|
Examples: []string{
|
|
"weknora agent delete ag_abc -y",
|
|
"weknora agent delete ag_abc -y --format json",
|
|
},
|
|
Warnings: []string{
|
|
"Requires explicit user approval (exit 10 / input.confirmation_required); never auto-add -y.",
|
|
"agent delete is irreversible; loses the agent + its KB binding + custom skills.",
|
|
},
|
|
})
|
|
return cmd
|
|
}
|
|
|
|
func runDelete(ctx context.Context, opts *DeleteOptions, fopts *cmdutil.FormatOptions, svc DeleteService, p prompt.Prompter) error {
|
|
if err := cmdutil.ConfirmDestructive(p, opts.Yes, fopts.WantsJSON(), "delete", "agent", opts.AgentID, "agent.delete", []string{"weknora", "agent", "delete", opts.AgentID, "-y"}); err != nil {
|
|
return err
|
|
}
|
|
if err := svc.DeleteAgent(ctx, opts.AgentID); err != nil {
|
|
return cmdutil.WrapHTTP(err, "delete agent %s", opts.AgentID)
|
|
}
|
|
if fopts.WantsJSON() {
|
|
return fopts.Emit(iostreams.IO.Out, deleteResult{ID: opts.AgentID, Deleted: true}, nil)
|
|
}
|
|
fmt.Fprintf(iostreams.IO.Out, "✓ Deleted agent %s\n", opts.AgentID)
|
|
return nil
|
|
}
|