From 98c53556adade5b8fe1cce9b932544a851df813f Mon Sep 17 00:00:00 2001 From: Florian Markusse Date: Fri, 6 Nov 2020 22:44:09 +0100 Subject: [PATCH] refactor: update isFilter in parameter.js(#6113) Changed assignment of "isFilter" twice due to redundant AND-operation with itself as the first operand since its value is true at the point of assignment. --- lib/middleware/parameter.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/middleware/parameter.js b/lib/middleware/parameter.js index 3d3be62615..4c9f1d9a4d 100644 --- a/lib/middleware/parameter.js +++ b/lib/middleware/parameter.js @@ -148,7 +148,7 @@ module.exports = async (ctx, next) => { const description = item.description || title; const author = item.author || ''; let isFilter = true; - ctx.query.filter_title && (isFilter = isFilter && title.match(makeRegex(ctx.query.filter_title))); + ctx.query.filter_title && (isFilter = title.match(makeRegex(ctx.query.filter_title))); ctx.query.filter_description && (isFilter = isFilter && description.match(makeRegex(ctx.query.filter_description))); ctx.query.filter_author && (isFilter = isFilter && author.match(makeRegex(ctx.query.filter_author))); return isFilter; @@ -165,7 +165,7 @@ module.exports = async (ctx, next) => { const description = item.description || title; const author = item.author || ''; let isFilter = true; - ctx.query.filterout_title && (isFilter = isFilter && !title.match(makeRegex(ctx.query.filterout_title))); + ctx.query.filterout_title && (isFilter = !title.match(makeRegex(ctx.query.filterout_title))); ctx.query.filterout_description && (isFilter = isFilter && !description.match(makeRegex(ctx.query.filterout_description))); ctx.query.filterout_author && (isFilter = isFilter && !author.match(makeRegex(ctx.query.filterout_author))); return isFilter;