mirror of
https://github.com/HKUDS/CLI-Anything.git
synced 2026-08-28 15:11:13 +08:00
Zhu Tianyi
f32fbf60bd
* fix(3mf): make inspect→resize work for non-default axes and concentric holes `inspect -a 2` could find a cylindrical hole, but `resize` then failed with "Unknown hole_ids: []"; and even when a hole was found its diameter was wrong and resize moved 0 vertices. Three root causes: 1. resize_holes() re-ran hole detection with hard-coded defaults and the resize CLI exposed no detection options, so hole_ids produced by a non-default `inspect` (e.g. --axis 2, --min-confidence) never lined up. Thread InspectParams through resize_holes() and mirror inspect's --planes/--min-diameter/--min-confidence/--axis options on `resize`. 2. _group_circles() clustered by centre only, so a hole's inner circle and the body's outer contour (both centred on the axis) merged and their radii averaged into a meaningless diameter. Cluster on (centre, radius). 3. A hole's axial extent came from the inset cross-section planes, so a through hole's rim vertices fell outside the wall-vertex band and resize moved nothing. Measure the extent from the actual wall vertices. Add regression tests for concentric grouping, true inner diameter, through-hole axial extent, and axis-param parity in resize_holes. All 122 tests pass. * fix(3mf): bound wall-vertex extent to the detected hole span Address review: _wall_axial_extent scanned every vertex by radius, so a coaxial same-radius feature elsewhere along the axis could stretch axis_min/axis_max past the inspected hole and make resize move unrelated vertices. Restrict the wall-vertex search to this group's detected span, extended by one sampling inset (shared backend.PLANE_INSET_FRACTION) and clamped to the mesh bounds, so through-hole rims are still recovered. Adds a regression test. * fix(3mf): reject outer contours so only interior holes are reported Address review: splitting circle groups by radius surfaced a round body's outer perimeter (annulus section) as its own high-confidence group, so inspect listed the part exterior as a resizable hole. Emit a hole only when the mesh has material radially outside the circle within its axial band -- true for an interior hole, false for the outer boundary, a boss, or a bare cylinder. The washer test now asserts the Ø40 outer wall is rejected; adds a solid-cylinder rejection test. * fix(3mf): classify holes by enclosure at both axial ends Address review: the "material outside the radius" check kept a solid boss that stands on a wider base, because the base rim vertices sit in the boss's axial band and are farther out than the boss radius. Require body material radially beyond the circle near BOTH ends of the extent instead: an interior hole is enclosed at both faces (or, for a blind hole, by its floor), while a boss is enclosed only at its base. Outer boundaries and bare cylinders remain rejected. Adds a boss-on-plate rejection test. * fix(3mf): classify holes by wall-normal orientation (keep blind holes) Address review: the both-ends enclosure check discarded blind pockets, whose closed-floor end has no vertices beyond the hole radius. Replace it with a surface-normal test: a hole's cylindrical wall faces the void so its normals point toward the axis, while an outer boundary, a bare cylinder, or a solid boss faces outward. This keeps through AND blind holes and still rejects those exterior contours, using the mesh's own face normals (no new dependency). If winding is inconsistent or the wall can't be sampled, keep the candidate rather than drop a real hole. Adds a blind-hole retention test.