From ca2fc20c59c28c0228f1e7a4366ef5679b617a8a Mon Sep 17 00:00:00 2001 From: KarandeepSWranch Date: Wed, 29 Apr 2026 04:46:42 -0700 Subject: [PATCH] fix(sbox): add deny-by-default .gitignore rules for sbox dir PR #251 reviewer (@yuh-yang) flagged that the original sbox commit only added Step 6 re-allow entries (!/sbox/, !/sbox/agent-harness/) but missed the Step 5 deny-by-default lines every other harness has. As a result, any non-harness file dropped into sbox/ (including dotfiles) was silently trackable, breaking the deny-by-default invariant the rest of the repo relies on. Verified before fix: $ git check-ignore -v sbox/foo.txt # no match (BUG) $ git check-ignore -v lldb/foo.txt # .gitignore:171:/lldb/* After this commit both should resolve to the matching Step 5 rule. Inserted right after the lldb block (lines 171-172) to match the insertion-order convention used for the other recent harness additions. --- .gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index e249ee9c6..e7be5c4cc 100644 --- a/.gitignore +++ b/.gitignore @@ -170,6 +170,8 @@ /nsight-graphics/.* /lldb/* /lldb/.* +/sbox/* +/sbox/.* # Step 6: ...except agent-harness/ !/gimp/agent-harness/